Use System.AccessToken for internal feed auth on release/9.0 - #67859
Merged
Conversation
Removing the credential entirely (relying only on NuGetAuthenticate) is insufficient because the Arcade toolset bootstrap restore reads credentials directly from NuGet.config. Pass the build identity OAuth token via legacyCredential so SetupNugetSources writes it to NuGet.config. Matches release/8.0 (#67854). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 331a413c-8b88-448e-8913-6ca49130a046
wtgodbe
reviewed
Jul 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release/9.0 Azure Pipelines build job to restore authentication to internal Azure DevOps artifact feeds by providing the build’s OAuth token to the internal-sources bootstrap step, ensuring toolset restore can read credentials directly from NuGet.config.
Changes:
- Pass
$(System.AccessToken)aslegacyCredentialinto theenable-internal-sourcesstep soSetupNugetSources.ps1can write live credentials intoNuGet.config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wtgodbe
approved these changes
Jul 16, 2026
Avoids forcing the enable-internal-sources template down the legacy PAT path for non-internal (e.g. DevDiv) projects, preserving the federated service-connection auth flow there. Addresses Copilot review feedback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 331a413c-8b88-448e-8913-6ca49130a046
wtgodbe
approved these changes
Jul 16, 2026
wtgodbe
added
the
tell-mode
This was referenced Aug 12, 2026
Open
Merged
This was referenced Aug 23, 2026
Bump Microsoft.AspNetCore.Mvc.Testing from 9.0.18 to 9.0.19
World-Sciences/world-sciences-website#21
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores internal feed authentication on
internal/release/9.0after thedn-bot-dnceng-artifact-feeds-rwPAT was removed from arcade's vault manifest and expired (1ES PAT Disable Policy), causing fleet-wide 401s ondarc-int-*/dotnet-*-internalfeeds.PR #67853 removed the
legacyCredentialPAT entirely, relying solely on theNuGetAuthenticate@1credential provider. That is insufficient: the Arcade toolset bootstrap restore (build.cmd->tools.ps1->restore.proj) reads credentials directly fromNuGet.configand does not consume the credential provider. Build 3024337 (commit 7ea898f, which contains #67853) still failed at toolset restore with all internal feeds unreachable.This PR passes the build identity's OAuth token via
legacyCredential: $(System.AccessToken), whichSetupNugetSources.ps1writes intoNuGet.configas a live, permissioned credential. Theinternal Build Service (dnceng)identity has collaborator/contributor on the affected feeds. This matches the release/8.0 approach (#67854) and the mechanism that worked prior to PAT expiry (a cleartext credential in config).Tracks AB#11679.