-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split .Components.Build into .Blazor.Build+.Components.Build #6538
Split .Components.Build into .Blazor.Build+.Components.Build #6538
Conversation
@rynowak @javiercn CR notes I know this PR isn't very easy to review and be certain it's correct, since most of the changes are just things moving from one place to another. The basic concept is that almost everything from Components.Build has moved to Blazor.Build, with the only remaining piece in Components.Build being the MSBuild props that enable the new Razor compilation features (and ultimately we will aim to remove this too, but not right now). It would be great to be able to merge this tomorrow (my time) because there's another chunky piece of work that depends on this. |
…n targets from there
1ed592d
to
f8b3bf4
Compare
@@ -31,6 +31,7 @@ This can be done once #4246 is complete, and done in conjunction with converting | |||
<PackageArtifact Include="Microsoft.AspNetCore.AzureAppServices.HostingStartup" Category="ship" /> | |||
<PackageArtifact Include="Microsoft.AspNetCore.AzureAppServicesIntegration" Category="ship" /> | |||
<PackageArtifact Include="Microsoft.AspNetCore.Blazor" Category="ship" /> | |||
<PackageArtifact Include="Microsoft.AspNetCore.Blazor.Build" Category="ship" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be in ship or just the components part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're shipping all the Blazor.* packages (to NuGet) as well as the Components.* ones (some of which will be in shared framework).
The only concern here that I have here is that any MSBuild we ship ultimately needs to go in some SDK or else it's very precarious. For instance if you get Components.Build through the shared framework, it won't do anything. VS if you reference it as a package it will do all of the things. Basically, we need to do work to rationalize all of this. I created an item to track defining how the MSBuild will work for a Component Class LIbrary, and I think the other thing that's tracked is rationalizing how all of this static file stuff works. I think this is an improvement for the time being and I'm glad to see it done 👍 |
I completely agree. My hope is that the MSBuild props set in this PR in The current state is just a stepping stone to the clean world of the future where these are all the defaults anyway :) |
This is also a concern for RazorClassLibraries. I would hope that whatever solution we find, it can be shared across both of them. |
This makes the WebAssembly-specific builds steps optional. If you reference
Microsoft.AspNetCore.Blazor.Build
then you get the WebAssembly+RazorComponents build, whereas if you referenceMicrosoft.AspNetCore.Components.Build
then you only get the RazorComponents part of the build.This is in preparation for a follow-up change that will eliminate the WebAssembly build steps entirely from the Razor Components template.