Factor WebAssembly debugging infrastructure out of Microsoft.AspNetCore.Components.Server #6519
Conversation
SteveSandersonMS
force-pushed
the
stevesa/factor-wasm-debugging-out-of-components-server
branch
from
dd2b3a2 to
2601fd9
Compare
| @@ -33,6 +33,7 @@ This can be done once #4246 is complete, and done in conjunction with converting | |||
| <PackageArtifact Include="Microsoft.AspNetCore.Blazor" Category="ship" /> | |||
| <PackageArtifact Include="Microsoft.AspNetCore.Blazor.Build" Category="ship" /> | |||
| <PackageArtifact Include="Microsoft.AspNetCore.Blazor.Cli" Category="ship" /> | |||
| <PackageArtifact Include="Microsoft.AspNetCore.Blazor.Server" Category="ship" /> | |||
| <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonPackageVersion)" /> | ||
|
|
||
| <!-- Used by ws-proxy sources only. Remove this once we're able to consume ws-proxy as a NuGet package. --> | ||
| <PackageReference Include="Mono.Cecil" Version="0.10.0-beta7" /> |
There was a problem hiding this comment.
I'm sure this will come up at some point, and it's OK to use an issue to track - but is there a stable version we can use? We don't generally want to depend on prerelease in release, and it looks like that would be easy to happen.
There was a problem hiding this comment.
Looks like there have been 2 stable releases of Mono.Cecil on nuget since the 0.10.0-beta7 version. Latest version: Mono.Cecil 0.10.1
There was a problem hiding this comment.
Good points. Thanks for the info. To avoid waiting for another long CI build, I'm going to make the Mono.Cecil version change in #6562.
| @@ -87,12 +87,6 @@ public static class BlazorApplicationBuilderExtensions | |||
| }); | |||
| } | |||
|
|
|||
| // Accept debugger connections | |||
| if (config.EnableDebugging) | |||
There was a problem hiding this comment.
Is there a plan/need to clean this up in BlazorConfig? Or is this a temporary thing while we figure out how to ship all of this.
Personally, I feel like having this show up in startup code is an improvement because it's more inline with our other diagnostics features.
There was a problem hiding this comment.
Yes, I'm sure we'll review and change the Blazor build/hosting mechanisms as we head towards a stable release of that.
natemcmaster
deleted the
stevesa/factor-wasm-debugging-out-of-components-server
branch
This is one of the steps in #6442