[release/9.0] Don't use netcoreapp2.1 in dotnet-get-document #64351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
added
the
tell-mode
wtgodbe
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to modernize the dotnet-getdocument tool by removing the legacy netcoreapp2.1 target framework. The tool now only targets net9.0 (via DefaultNetCoreTargetFramework).
Key changes:
- Removed
netcoreapp2.1from theTargetFrameworksproperty in the project file - Simplified the tools directory resolution logic by removing version-specific conditionals
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj | Removed netcoreapp2.1 from TargetFrameworks, now only targeting net9.0 |
| src/Tools/dotnet-getdocument/src/Commands/InvokeCommand.cs | Simplified tools directory resolution to use net{version} format for all .NET Core versions |
This was referenced Jan 13, 2026
Closed
This was referenced Jan 15, 2026
Open
Open
Closed
Open
Closed
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netcoreapp2.1 is no longer supported