Fix test EmbeddingServerAppInsideIframe_WithCompressionEnabled_Fails #64326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
reviewed
Nov 12, 2025
src/Components/test/E2ETest/ServerExecutionTests/WebSocketCompressionTests.cs
Outdated
Show resolved
Hide resolved
ilonatommy
approved these changes
Nov 12, 2025
Member
ilonatommy
left a comment
ilonatommy
left a comment
There was a problem hiding this comment.
Small update so that we see what did not get matched, without browsing the code.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a failing test caused by changes in Chromium's error message format for Content Security Policy (CSP) violations. The test now checks for both the old and new error message patterns to ensure compatibility across different Chromium versions.
- Removed the
[QuarantinedTest]attribute to enable the test - Updated the assertion logic to support both old and new Chromium CSP error message formats
- Added a new regex pattern for the updated Chromium error message
…ressionTests.cs Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Member
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
wtgodbe
pushed a commit
that referenced
this pull request
Jan 6, 2026
* Update dependencies from https://github.com/dotnet/arcade build 20251127.5 On relative base path root Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor From Version 9.0.0-beta.25562.4 -> To Version 9.0.0-beta.25577.5 * Fix test EmbeddingServerAppInsideIframe_WithCompressionEnabled_Fails (#64326) (cherry picked from commit c4f8522) * Quarantine CanSendAndReceiveUserMessagesFromMultipleConnectionsWithSameUser (#59992) (cherry picked from commit 2f9d787) * Quarantine CanSendAndReceiveUserMessagesUserNameWithPatternIsTreatedAsLiteral test Port of same change from 8.0 in #63565 * Update dependencies from https://github.com/dotnet/arcade build 20251211.4 On relative base path root Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor From Version 9.0.0-beta.25562.4 -> To Version 9.0.0-beta.25611.4 * Update dependencies from https://github.com/dotnet/arcade build 20251226.6 On relative base path root Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor From Version 9.0.0-beta.25562.4 -> To Version 9.0.0-beta.25626.6 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Daria Tiurina <dariatiurina@microsoft.com> Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
ofir-frd
pushed a commit
to qodo-benchmark/aspnetcore
that referenced
this pull request
Jan 21, 2026
…otnet#64326) (cherry picked from commit c4f8522)
ofir-frd
pushed a commit
to qodo-benchmark/aspnetcore
that referenced
this pull request
Jan 21, 2026
…otnet#64326) (cherry picked from commit c4f8522)
ofir-frd
pushed a commit
to qodo-benchmark/aspnetcore
that referenced
this pull request
Jan 21, 2026
…otnet#64326) (cherry picked from commit c4f8522)
ofir-frd
pushed a commit
to qodo-benchmark/aspnetcore
that referenced
this pull request
Jan 21, 2026
…otnet#64326) (cherry picked from commit c4f8522)
tomerqodo
pushed a commit
to qodo-benchmark/aspnetcore
that referenced
this pull request
Jan 21, 2026
…otnet#64326) (cherry picked from commit c4f8522)
tomerqodo
pushed a commit
to qodo-benchmark/aspnetcore
that referenced
this pull request
Jan 21, 2026
…otnet#64326) (cherry picked from commit c4f8522)
tomerqodo
pushed a commit
to agentic-review-benchmarks/aspnetcore
that referenced
this pull request
Jan 25, 2026
…otnet#64326) (cherry picked from commit c4f8522)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test EmbeddingServerAppInsideIframe_WithCompressionEnabled_Fails
Description
This pull request changes the error message check in the test due to changes in the Chromium. This makes test not fail anymore.
Changes:
[QuarantinedTest]attribute from the test.Fixes #64305