Skip to content

Update Selenium and Playwright versions #62532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Jul 1, 2025

It's the start of the month, so it's time to update these dependencies as part of my build-ops rotation.

@halter73 halter73 requested review from a team and wtgodbe as code owners July 1, 2025 23:33
@github-actions github-actions bot added the area-blazor Includes: Blazor, Razor Components label Jul 1, 2025
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halter73 @wtgodbe there's a GH action for this.

I'm not sure why it isn't working, but maybe it's worth looking into it

@martincostello
Copy link
Member

I'm not sure why it isn't working, but maybe it's worth looking into it

Looks like it failed to push the changes because the branch wasn't deleted when the first PR that did it was merged, so there's push conflicts.

Dangling branch

To https://github.com/dotnet/aspnetcore
 ! [rejected]          infrastructure/update-selenium-and-typescript-dependencies -> infrastructure/update-selenium-and-typescript-dependencies (fetch first)
error: failed to push some refs to 'https://github.com/dotnet/aspnetcore'
hint: Updates were rejected because the remote contains work that you do not
hint: have locally. This is usually caused by another repository pushing to
hint: the same ref. If you want to integrate the remote changes, use
hint: 'git pull' before pushing again.

@halter73
Copy link
Member Author

halter73 commented Jul 2, 2025

Dangling branch

Thanks for investigating. I deleted the branch. Hopefully, the next time we get the PR we merge it and delete the branch in time.

@javiercn
Copy link
Member

javiercn commented Jul 2, 2025

Or we could try and update the script to remove the branch, force push on the existing one or create a separate branch? yyyy-mm-dd or something like that.

@halter73 halter73 merged commit 1eda538 into main Jul 3, 2025
28 of 30 checks passed
@halter73 halter73 deleted the halter73/selenium-update branch July 3, 2025 18:01
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview7 milestone Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants