Flip switch for controlling navigation flow on SSR #62358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
requested review from
Copilot
and removed request for
a team and
wtgodbe
There was a problem hiding this comment.
Pull Request Overview
This PR renames the navigation exception switch and updates its usage across the codebase to support a unified navigation flow for SSR while allowing SSR code to run after navigation. Key changes include renaming the switch from EnableThrowNavigationException to DisableThrowNavigationException, updating test logic with the new inverted parameter, and modifying the navigation manager implementations accordingly.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/submodules/googletest | Updated subproject commit hash |
| src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/Program.cs | Set the new switch to true for templates |
| src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/Program.Main.cs | Set the new switch to true for templates |
| src/Components/test/E2ETest/ServerRenderingTests/NoInteractivityTest.cs | Inverted switch logic in tests |
| src/Components/test/E2ETest/ServerRenderingTests/InteractivityTest.cs | Inverted switch logic in tests |
| src/Components/Server/src/Circuits/RemoteNavigationManager.cs | Updated constant name and switch logic for remote navigation |
| src/Components/Endpoints/test/EndpointHtmlRendererTest.cs | Inverted switch logic in endpoint tests |
| src/Components/Endpoints/src/DependencyInjection/HttpNavigationManager.cs | Updated constant name and switch logic for HTTP navigation |
src/Components/Endpoints/src/DependencyInjection/HttpNavigationManager.cs
Outdated
Show resolved
Hide resolved
javiercn
reviewed
Jun 16, 2025
...jectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Program.Main.cs
Outdated
Show resolved
Hide resolved
javiercn
reviewed
Jun 16, 2025
src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Program.cs
Outdated
Show resolved
Hide resolved
3 tasks
2 tasks
javiercn
reviewed
Jun 16, 2025
javiercn
approved these changes
Jun 16, 2025
javiercn
reviewed
Jun 16, 2025
akoeplinger
pushed a commit
to dotnet/sdk
that referenced
this pull request
Jun 16, 2025
For dotnet/aspnetcore#62358. Defines a switch that can be controlled by `BlazorDisableThrowNavigationException` property.
|
/backport to release/10.0-preview6 |
|
Started backporting to release/10.0-preview6: https://github.com/dotnet/aspnetcore/actions/runs/15709205261 |
10 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation with
NavigationExceptionstays the default behavior for SSR navigationSwitch was introduced in #61306. The PR unifies the navigation across render modes but also allows SSR code after the navigation to run. Upgrading the application could lead to unexpected behaviors, e.g. see how templates had to be changed to adjust to the new navigation: #62105. From this reason, we decided to keep the default behavior for the exception flow. It can be changed by setting
Microsoft.AspNetCore.Components.Endpoints.NavigationManager.DisableThrowNavigationExceptionswitch. New projects will use the new way of working.Description
This PR:
EnableThrowNavigationException->DisableThrowNavigationException,DisableThrowNavigationException: falseby default,DisableThrowNavigationException: truein the templates.