-
Notifications
You must be signed in to change notification settings - Fork 10.3k
feat: support tls client hello bytes callback in Kestrel #61631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DeagleGross
wants to merge
20
commits into
dotnet:main
Choose a base branch
from
DeagleGross:dmkorolev/kestrel-tls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+864
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfoidl
reviewed
Apr 23, 2025
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
gfoidl
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- just a small comment.
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerMiddlewareTests.cs
Show resolved
Hide resolved
src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerMiddlewareTests.Units.cs
Outdated
Show resolved
Hide resolved
3 tasks
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/Core/src/Middleware/TlsListenerMiddleware.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerMiddlewareTests.Units.cs
Outdated
Show resolved
Hide resolved
src/Servers/Kestrel/test/InMemory.FunctionalTests/TlsListenerMiddlewareTests.Units.cs
Outdated
Show resolved
Hide resolved
… duplicate registration
add tests for SSL 2.0 and SSL 3.0 |
done |
src/Servers/Kestrel/test/InMemory.FunctionalTests/TestTransport/InMemoryTransportConnection.cs
Outdated
Show resolved
Hide resolved
BrennanConroy
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-networking
Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting TLS Client Hello callback in Kestrel
HTTP.SYS contribution was done in this PR
Description
Adding a new property to
HttpsConnectionAdapterOptions
-TlsClientHelloBytesCallback
(added to public API).It allows to subscribe to the TLS client hello message parsed from the
ConnectionContext.Transport.Input
:If property
HttpsConnectionAdapterOptions.TlsClientHelloBytesCallback
is set (not null), then new middleware is added beforeHttpsConnectionMiddleware
.The implementation is doing the following:
Fixes #60805