Enable static code analysis pilot in pipeline #60743
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-infrastructure
There was a problem hiding this comment.
PR Overview
This pull request enables a static code analysis pilot within the CI pipeline by adding new configuration flags.
- Enables a new policy ("MicrosoftCanary")
- Activates the prefast analysis with break enabled and sets its severity to CriticalError
- Sets new feature flags for prefast versioning and enablement check
Reviewed Changes
| File | Description |
|---|---|
| .azure/pipelines/ci.yml | New static code analysis settings added to the pipeline configuration |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.azure/pipelines/ci.yml:131
- Verify that 'CriticalError' is an accepted value for severity. Some systems expect severity levels in a specific format, such as lowercase.
severity: CriticalError
.azure/pipelines/ci.yml:134
- [nitpick] Consider renaming 'checkIfEnablePrefast' to a more concise flag, such as 'enablePrefastCheck', to improve clarity and maintain consistency with similar flag naming.
checkIfEnablePrefast: false
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
|
Internal build failed - working w/ the static analysis team to figure out a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on static code analysis feature in SDL