Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert trimming test workarounds #58272

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

MackinnonBuck
Copy link
Member

Now that dotnet/sdk#43070 is merged, we should be able to revert the linker workarounds applied in #57742.

Fixes #57846

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-signalr Includes: SignalR clients and servers label Oct 7, 2024
@MackinnonBuck MackinnonBuck added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed area-signalr Includes: SignalR clients and servers labels Oct 7, 2024
@BrennanConroy
Copy link
Member

We need to get the updated sdk first though?

@MackinnonBuck
Copy link
Member Author

We need to get the updated sdk first though?

Yep, I'll change the base of this PR to the SDK update PR when it gets opened.

@BrennanConroy BrennanConroy changed the base branch from main to BrennanConroy-patch-2 October 15, 2024 22:02
src/Components/Forms/src/FieldIdentifier.cs Outdated Show resolved Hide resolved
src/Components/Forms/src/FieldIdentifier.cs Outdated Show resolved Hide resolved
src/SignalR/server/Core/src/DynamicHub.cs Show resolved Hide resolved
src/SignalR/server/Core/src/DynamicHub.cs Outdated Show resolved Hide resolved
src/SignalR/server/Core/src/DynamicHubClients.cs Outdated Show resolved Hide resolved
src/SignalR/server/Core/src/DynamicHubClients.cs Outdated Show resolved Hide resolved
src/SignalR/server/Core/src/Internal/DynamicClientProxy.cs Outdated Show resolved Hide resolved
src/SignalR/server/Core/src/Internal/DynamicClientProxy.cs Outdated Show resolved Hide resolved
Base automatically changed from BrennanConroy-patch-2 to main October 16, 2024 16:43
@BrennanConroy BrennanConroy marked this pull request as ready for review October 16, 2024 16:43
@BrennanConroy BrennanConroy enabled auto-merge (squash) October 16, 2024 23:56
@BrennanConroy BrennanConroy merged commit 109c0d4 into main Oct 17, 2024
26 checks passed
@BrennanConroy BrennanConroy deleted the mbuck/revert-trimming-test-workarounds branch October 17, 2024 01:53
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove trimming tests workaround for runtime bug
3 participants