Skip to content

Update warning suppressions and cache ParameterInfo[] in generated code #56979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2024
Merged

Update warning suppressions and cache ParameterInfo[] in generated code #56979

merged 1 commit into from
Jul 29, 2024

Conversation

captainsafia
Copy link
Member

Reacting to follow-ups from #56827.

  • Add justification to warning suppression on ModelMetadata
  • Cache ParmaterInfo[] used to insert parameter bidning metadata in RDG

cc: @BrennanConroy @eerhardt

@captainsafia captainsafia requested review from a team, BrennanConroy and halter73 as code owners July 24, 2024 16:59
@ghost ghost added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Jul 24, 2024
@captainsafia captainsafia added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions labels Jul 24, 2024
eerhardt
eerhardt approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@captainsafia captainsafia merged commit 3c6fc94 into main Jul 29, 2024
26 checks passed
@captainsafia captainsafia deleted the aot-follow-ups branch July 29, 2024 16:09
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc1 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc
Projects
None yet
Milestone
9.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@captainsafia @eerhardt