Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic variants of ProducesProblem and ProducesValidationProblem #56810

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Add generic variants of ProducesProblem and ProducesValidationProblem #56810

merged 2 commits into from
Jul 17, 2024

Conversation

captainsafia
Copy link
Member

Closes #56178.

@captainsafia captainsafia requested a review from javiercn as a code owner July 15, 2024 23:16
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Jul 15, 2024
@captainsafia captainsafia requested review from mikekistler and a team July 15, 2024 23:16
mikekistler
mikekistler approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

BrennanConroy
BrennanConroy approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could use a const string for the content-type I believe one is available on some type somewhere 😆

@captainsafia captainsafia force-pushed the safia/produces-problem branch from fde9f39 to ca38972 Compare July 17, 2024 18:30
@captainsafia captainsafia requested a review from halter73 as a code owner July 17, 2024 18:30
@captainsafia captainsafia enabled auto-merge (squash) July 17, 2024 18:31
@captainsafia captainsafia merged commit a21c9ed into main Jul 17, 2024
26 checks passed
@captainsafia captainsafia deleted the safia/produces-problem branch July 17, 2024 20:54
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview7 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekistler mikekistler mikekistler approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@javiercn javiercn Awaiting requested review from javiercn

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Milestone
9.0-preview7
Development

Successfully merging this pull request may close these issues.

Produces generic variants of ProducesProblem extension methods
3 participants
@captainsafia @BrennanConroy @mikekistler