Skip to content

Perf: ReasonPhrases as Array instead of Dictionary #56304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Perf: ReasonPhrases as Array instead of Dictionary #56304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ff043d0
ReasonPhrases as switch instead of Dictionary
WhatzGames Jun 18, 2024
cff6b26
Revert "ReasonPhrases as switch instead of Dictionary"
WhatzGames Jun 24, 2024
499c5a7
ReasonPhrases as FrozenDictionary instead of Dictionary
WhatzGames Jun 24, 2024
9a976cb
ReasonPhrases to Array implementation
WhatzGames Jul 2, 2024
84d4f98
remove unnecessary using directive
WhatzGames Jul 2, 2024
344293d
Reduce bounds checks and branches
WhatzGames Jul 4, 2024
4447ca5
Replaced HttpReasonPhrase with ReasonPhrase
WhatzGames Jul 4, 2024
fcb05bd
removed extra whitespace
WhatzGames Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
245 changes: 174 additions & 71 deletions src/Http/WebUtilities/src/ReasonPhrases.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,76 +10,170 @@ namespace Microsoft.AspNetCore.WebUtilities;
public static class ReasonPhrases
{
// Status Codes listed at http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
private static readonly Dictionary<int, string> Phrases = new()
{
{ 100, "Continue" },
{ 101, "Switching Protocols" },
{ 102, "Processing" },

{ 200, "OK" },
{ 201, "Created" },
{ 202, "Accepted" },
{ 203, "Non-Authoritative Information" },
{ 204, "No Content" },
{ 205, "Reset Content" },
{ 206, "Partial Content" },
{ 207, "Multi-Status" },
{ 208, "Already Reported" },
{ 226, "IM Used" },

{ 300, "Multiple Choices" },
{ 301, "Moved Permanently" },
{ 302, "Found" },
{ 303, "See Other" },
{ 304, "Not Modified" },
{ 305, "Use Proxy" },
{ 306, "Switch Proxy" },
{ 307, "Temporary Redirect" },
{ 308, "Permanent Redirect" },

{ 400, "Bad Request" },
{ 401, "Unauthorized" },
{ 402, "Payment Required" },
{ 403, "Forbidden" },
{ 404, "Not Found" },
{ 405, "Method Not Allowed" },
{ 406, "Not Acceptable" },
{ 407, "Proxy Authentication Required" },
{ 408, "Request Timeout" },
{ 409, "Conflict" },
{ 410, "Gone" },
{ 411, "Length Required" },
{ 412, "Precondition Failed" },
{ 413, "Payload Too Large" },
{ 414, "URI Too Long" },
{ 415, "Unsupported Media Type" },
{ 416, "Range Not Satisfiable" },
{ 417, "Expectation Failed" },
{ 418, "I'm a teapot" },
{ 419, "Authentication Timeout" },
{ 421, "Misdirected Request" },
{ 422, "Unprocessable Entity" },
{ 423, "Locked" },
{ 424, "Failed Dependency" },
{ 426, "Upgrade Required" },
{ 428, "Precondition Required" },
{ 429, "Too Many Requests" },
{ 431, "Request Header Fields Too Large" },
{ 451, "Unavailable For Legal Reasons" },
{ 499, "Client Closed Request" },

{ 500, "Internal Server Error" },
{ 501, "Not Implemented" },
{ 502, "Bad Gateway" },
{ 503, "Service Unavailable" },
{ 504, "Gateway Timeout" },
{ 505, "HTTP Version Not Supported" },
{ 506, "Variant Also Negotiates" },
{ 507, "Insufficient Storage" },
{ 508, "Loop Detected" },
{ 510, "Not Extended" },
{ 511, "Network Authentication Required" },
};
private static readonly string[][] HttpReasonPhrases = [
[],
[
/* 100 */ "Continue",
/* 101 */ "Switching Protocols",
/* 102 */ "Processing"
],
[
/* 200 */ "OK",
/* 201 */ "Created",
/* 202 */ "Accepted",
/* 203 */ "Non-Authoritative Information",
/* 204 */ "No Content",
/* 205 */ "Reset Content",
/* 206 */ "Partial Content",
/* 207 */ "Multi-Status",
/* 208 */ "Already Reported",
/* 209 */ string.Empty,
/* 210 */ string.Empty,
/* 211 */ string.Empty,
/* 212 */ string.Empty,
/* 213 */ string.Empty,
/* 214 */ string.Empty,
/* 215 */ string.Empty,
/* 216 */ string.Empty,
/* 217 */ string.Empty,
/* 218 */ string.Empty,
/* 219 */ string.Empty,
/* 220 */ string.Empty,
/* 221 */ string.Empty,
/* 222 */ string.Empty,
/* 223 */ string.Empty,
/* 224 */ string.Empty,
/* 225 */ string.Empty,
/* 226 */ "IM Used"
],
[
/* 300 */ "Multiple Choices",
/* 301 */ "Moved Permanently",
/* 302 */ "Found",
/* 303 */ "See Other",
/* 304 */ "Not Modified",
/* 305 */ "Use Proxy",
/* 306 */ "Switch Proxy",
/* 307 */ "Temporary Redirect",
/* 308 */ "Permanent Redirect"
],
[
/* 400 */ "Bad Request",
/* 401 */ "Unauthorized",
/* 402 */ "Payment Required",
/* 403 */ "Forbidden",
/* 404 */ "Not Found",
/* 405 */ "Method Not Allowed",
/* 406 */ "Not Acceptable",
/* 407 */ "Proxy Authentication Required",
/* 408 */ "Request Timeout",
/* 409 */ "Conflict",
/* 410 */ "Gone",
/* 411 */ "Length Required",
/* 412 */ "Precondition Failed",
/* 413 */ "Payload Too Large",
/* 414 */ "URI Too Long",
/* 415 */ "Unsupported Media Type",
/* 416 */ "Range Not Satisfiable",
/* 417 */ "Expectation Failed",
/* 418 */ "I'm a teapot",
/* 419 */ "Authentication Timeout",
/* 420 */ string.Empty,
/* 421 */ "Misdirected Request",
/* 422 */ "Unprocessable Entity",
/* 423 */ "Locked",
/* 424 */ "Failed Dependency",
/* 425 */ string.Empty,
/* 426 */ "Upgrade Required",
/* 427 */ string.Empty,
/* 428 */ "Precondition Required",
/* 429 */ "Too Many Requests",
/* 430 */ string.Empty,
/* 431 */ "Request Header Fields Too Large",
/* 432 */ string.Empty,
/* 433 */ string.Empty,
/* 434 */ string.Empty,
/* 435 */ string.Empty,
/* 436 */ string.Empty,
/* 437 */ string.Empty,
/* 438 */ string.Empty,
/* 439 */ string.Empty,
/* 440 */ string.Empty,
/* 441 */ string.Empty,
/* 442 */ string.Empty,
/* 443 */ string.Empty,
/* 444 */ string.Empty,
/* 445 */ string.Empty,
/* 446 */ string.Empty,
/* 447 */ string.Empty,
/* 448 */ string.Empty,
/* 449 */ string.Empty,
/* 450 */ string.Empty,
/* 451 */ "Unavailable For Legal Reasons",
/* 452 */ string.Empty,
/* 453 */ string.Empty,
/* 454 */ string.Empty,
/* 455 */ string.Empty,
/* 456 */ string.Empty,
/* 457 */ string.Empty,
/* 458 */ string.Empty,
/* 459 */ string.Empty,
/* 460 */ string.Empty,
/* 461 */ string.Empty,
/* 462 */ string.Empty,
/* 463 */ string.Empty,
/* 464 */ string.Empty,
/* 465 */ string.Empty,
/* 466 */ string.Empty,
/* 467 */ string.Empty,
/* 468 */ string.Empty,
/* 469 */ string.Empty,
/* 470 */ string.Empty,
/* 471 */ string.Empty,
/* 472 */ string.Empty,
/* 473 */ string.Empty,
/* 474 */ string.Empty,
/* 475 */ string.Empty,
/* 476 */ string.Empty,
/* 477 */ string.Empty,
/* 478 */ string.Empty,
/* 479 */ string.Empty,
/* 480 */ string.Empty,
/* 481 */ string.Empty,
/* 482 */ string.Empty,
/* 483 */ string.Empty,
/* 484 */ string.Empty,
/* 485 */ string.Empty,
/* 486 */ string.Empty,
/* 487 */ string.Empty,
/* 488 */ string.Empty,
/* 489 */ string.Empty,
/* 490 */ string.Empty,
/* 491 */ string.Empty,
/* 492 */ string.Empty,
/* 493 */ string.Empty,
/* 494 */ string.Empty,
/* 495 */ string.Empty,
/* 496 */ string.Empty,
/* 497 */ string.Empty,
/* 498 */ string.Empty,
/* 499 */ "Client Closed Request"
],
[
/* 500 */ "Internal Server Error",
/* 501 */ "Not Implemented",
/* 502 */ "Bad Gateway",
/* 503 */ "Service Unavailable",
/* 504 */ "Gateway Timeout",
/* 505 */ "HTTP Version Not Supported",
/* 506 */ "Variant Also Negotiates",
/* 507 */ "Insufficient Storage",
/* 508 */ "Loop Detected",
/* 509 */ string.Empty,
/* 510 */ "Not Extended",
/* 511 */ "Network Authentication Required"
]
];

/// <summary>
/// Gets the reason phrase for the specified status code.
Expand All @@ -88,6 +182,15 @@ public static class ReasonPhrases
/// <returns>The reason phrase, or <see cref="string.Empty"/> if the status code is unknown.</returns>
public static string GetReasonPhrase(int statusCode)
{
return Phrases.TryGetValue(statusCode, out var phrase) ? phrase : string.Empty;
if ((uint)(statusCode - 100) < 500)
{
var (i, j) = Math.DivRem((uint)statusCode, 100);
string[] phrases = HttpReasonPhrases[i];
if (j < (uint)phrases.Length)
{
return phrases[j];
}
}
return string.Empty;
}
}
3 changes: 2 additions & 1 deletion src/Servers/HttpSys/src/HttpSysListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System.Diagnostics;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.HttpSys.Internal;
using Microsoft.AspNetCore.WebUtilities;
using Microsoft.Extensions.Logging;
using Windows.Win32;
using Windows.Win32.Foundation;
Expand Down Expand Up @@ -352,7 +353,7 @@ internal unsafe void SendError(ulong requestId, int httpStatusCode, IList<string
}

httpResponse.Base.StatusCode = checked((ushort)httpStatusCode);
var statusDescription = HttpReasonPhrase.Get(httpStatusCode) ?? string.Empty;
var statusDescription = ReasonPhrases.GetReasonPhrase(httpStatusCode);
uint dataWritten = 0;
uint statusCode;

Expand Down
100 changes: 0 additions & 100 deletions src/Servers/HttpSys/src/RequestProcessing/HttpReasonPhrase.cs
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion src/Servers/HttpSys/src/RequestProcessing/RequestContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System.Security.Principal;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.HttpSys.Internal;
using Microsoft.AspNetCore.WebUtilities;
using Microsoft.Extensions.Logging;
using Windows.Win32;
using Windows.Win32.Networking.HttpServer;
Expand Down Expand Up @@ -101,7 +102,7 @@ public Task<Stream> UpgradeAsync()

// Set the status code and reason phrase
Response.StatusCode = StatusCodes.Status101SwitchingProtocols;
Response.ReasonPhrase = HttpReasonPhrase.Get(StatusCodes.Status101SwitchingProtocols);
Response.ReasonPhrase = ReasonPhrases.GetReasonPhrase(StatusCodes.Status101SwitchingProtocols);

Response.SendOpaqueUpgrade(); // TODO: Async
Request.SwitchToOpaqueMode();
Expand Down
Loading
Loading