Add disable HTTP metrics endpoint metadata #56036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campersau
reviewed
Jun 3, 2024
src/Http/Http.Extensions/src/HttpMetricsEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
Kahbazi
reviewed
Jun 7, 2024
src/Http/Http.Extensions/src/HttpMetricsEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
JamesNK
force-pushed
the
jamesnk/disablehttpmetricsmetadata
branch
from
f3fa7d1 to
40dabd3
Compare
JamesNK
requested review from
javiercn,
BrennanConroy,
halter73 and
captainsafia
as code owners
JamesNK
commented
Jun 28, 2024
src/Http/Http.Extensions/src/HttpMetricsEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
|
This is done and is ready for review. |
amcasey
reviewed
Jul 9, 2024
| /// <summary> | ||
| /// A marker interface which can be used to identify metadata that disables HTTP request duration metrics. | ||
| /// </summary> | ||
| public interface IDisableHttpMetricsMetadata |
There was a problem hiding this comment.
What's the flag interface for? Relatedly, if there's only one concrete implementation, can we just use that?
There was a problem hiding this comment.
Using interfaces for endpoint metadata is the normal pattern. The only implementation is an attribute. Internally, builder methods that add this metadata to the endpoint just add the attribute.
JamesNK
force-pushed
the
jamesnk/disablehttpmetricsmetadata
branch
from
899f687 to
67924e5
Compare
captainsafia
approved these changes
Jul 11, 2024
src/Http/Http.Extensions/src/HttpMetricsEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
JamesNK
force-pushed
the
jamesnk/disablehttpmetricsmetadata
branch
from
9a77edc to
c89dad3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56039
Fixes #50654