Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Pass dotnetEfVersion in Helix test runner #52103

Open
wants to merge 1 commit into
base: release/8.0
Choose a base branch
from
Open

[release/8.0] Pass dotnetEfVersion in Helix test runner #52103

wants to merge 1 commit into from

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Nov 15, 2023

Port of a test fix from 7.0. Without this, the Helix Test Runner downloads the latest stable dotnet-ef from nuget.org, so once 9.0 ships, 8.0 tests using dotnet-ef will fail.

@wtgodbe wtgodbe requested a review from a team as a code owner November 15, 2023 22:36
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 15, 2023
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 15, 2023
@ghost ghost added this to the 8.0.x milestone Nov 15, 2023
@ghost
Copy link

ghost commented Nov 15, 2023

Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost
Copy link

ghost commented Nov 15, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Nov 15, 2023
@wtgodbe wtgodbe mentioned this pull request Nov 15, 2023
Merged
@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 23, 2023
@wtgodbe wtgodbe added the * NO MERGE * Do not merge this PR as long as this label is present. label Jan 3, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment Feb 13, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MackinnonBuck MackinnonBuck MackinnonBuck approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework * NO MERGE * Do not merge this PR as long as this label is present. pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun tell-mode Indicates a PR which is being merged during tell-mode
Projects
Servicing
Status: In Progress
Milestone
8.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@wtgodbe @MackinnonBuck