Fix pRequestInfo INVALID_POINTER_READ caused by GCs#50446
Merged
Tratcher merged 1 commit intoAug 31, 2023
Conversation
|
Thanks for your PR, @NGloreous. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This was referenced Aug 31, 2023
gfoidl
reviewed
Aug 31, 2023
Member
|
Once merged this will also need to be backported to release/8.0. There's a bot we can use for that. |
Tratcher
approved these changes
Aug 31, 2023
Member
|
/backport to release/8.0 |
Contributor
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/6040761798 |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix pRequestInfo INVALID_POINTER_READ caused by GCs
Description
When using the IHttpSysRequestInfoFeature it's possible to hit invalid pointer read errors which causes a process crash. It's also possible to hit other issue caused by the invalid pointer. The error occurs when a GC moves to memory of the request's _backingBuffer before trying to access the RequestInfo property of IHttpSysRequestInfoFeature.
The fix is to adjust the pRequestInfo pointer similar to how other pointers in this class are adjusted.
Fixes #50445