Set Hot Reload controlling headers DOTNET-MODIFIABLE-ASSEMBLIES and A… #48953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
approved these changes
Jun 22, 2023
…SPNETCORE-BROWSER-TOOLS regardless of the environment kind
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
ghost
added
the
pending-ci-rerun
|
/azp run |
|
Hi @tmat. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
ghost
removed
the
pending-ci-rerun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…SPNETCORE-BROWSER-TOOLS regardless of the environment kind
The tool that launches the app (dotnet-watch/VS) should be in control of when Hot Reload is enabled. This choice should not be overridden by ASP.NET. Doing so results in inconsistencies where VS/dotnet-watch think Hot Reload is enabled, but it actually isn't.
Fixes #47836