Skip to content

Reduce record usage in published projects #48907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jul 22, 2023
Merged

Reduce record usage in published projects #48907

merged 31 commits into from
Jul 22, 2023

Conversation

david-acker
Copy link
Member

Reduce record usage in published projects

Converts instances of record to class and record struct to struct.

Fixes #45859

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 20, 2023
@ghost
Copy link

ghost commented Jun 20, 2023

Thanks for your PR, @david-acker. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@ghost ghost added the area-runtime label Jun 20, 2023
@david-acker
Copy link
Member Author

FYI I'll be taking a quick look through the projects again just to make sure I didn't miss anything.

@david-acker david-acker force-pushed the reduce-record-usage branch from 9d025f7 to e67bb69 Compare June 21, 2023 02:54
@adityamandaleeka
Copy link
Member

Thanks @david-acker! Looks like you have some merge conflicts.

@david-acker david-acker requested a review from captainsafia July 7, 2023 16:06
captainsafia
captainsafia approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Would be good to get a look from @dotnet/aspnet-blazor-eng to cover the changes under src/Components and @amcasey for review on the src/Server changes.

amcasey
amcasey approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me (the Server folder).

@ghost
Copy link

ghost commented Jul 21, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 21, 2023
@adityamandaleeka
Copy link
Member

@dotnet/aspnet-blazor-eng Can someone please take a quick look at the src/Components changes so we can get this in for .NET 8?

@david-acker
Copy link
Member Author

david-acker commented Jul 21, 2023 •
edited
Loading

Could someone with commit rights use /azp run?

Edit: Need to fix some merge conflicts first.

@david-acker
Copy link
Member Author

Other changes:

  • Converted SequenceAndKey(which was recently added to EndpointHtmlRenderer.Streaming.cs) from a record struct to a struct.
  • Re-converted FormDataConverterReadParameters (from ComplextTypeExpressionConverterFactoryOfT.cs) to a struct. It looks like this was moved to a different file recently and didn't retain the original changes.

@david-acker david-acker removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jul 21, 2023
@adityamandaleeka
Copy link
Member

Thanks @david-acker!

@adityamandaleeka adityamandaleeka merged commit defbb65 into dotnet:main Jul 22, 2023
@ghost ghost added this to the 8.0-rc1 milestone Jul 22, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
@david-acker david-acker deleted the reduce-record-usage branch October 26, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcasey amcasey amcasey approved these changes

@captainsafia captainsafia captainsafia approved these changes

@javiercn javiercn javiercn approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees

@adityamandaleeka adityamandaleeka

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0-rc1
Development

Successfully merging this pull request may close these issues.

Reduce record usage in published aspnetcore projects
6 participants
@david-acker @adityamandaleeka @captainsafia @javiercn @BrennanConroy @amcasey