Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try updating to python3 #48367

Merged
merged 7 commits into from
May 23, 2023
Merged

Try updating to python3 #48367

merged 7 commits into from
May 23, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented May 22, 2023

Attempt to resolve #48221

@wtgodbe wtgodbe requested a review from a team as a code owner May 22, 2023 18:30
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 22, 2023
@wtgodbe wtgodbe requested a review from sbomer May 22, 2023 22:43
sbomer
sbomer approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wtgodbe
Copy link
Member Author

wtgodbe commented May 22, 2023

@sbomer do any of the #!/usr/bin/python headers need to change?

@sbomer
Copy link
Member

sbomer commented May 22, 2023

Yes, same advice applies there - those would ideally use the versioned command too.

@wtgodbe wtgodbe merged commit 6c66253 into dotnet:main May 23, 2023
@ghost ghost added this to the 8.0-preview5 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbomer sbomer sbomer approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
8.0-preview5
Development

Successfully merging this pull request may close these issues.

Use versioned python3 command in scripts
2 participants
@wtgodbe @sbomer