Update JSInProcessObjectReference.cs

[LostBeard]

Fix for bug #48280 "Exception calling Dispose on IJSInProcessObjectReference instance in Blazor WebAssembly"

• [ x ] You've read the Contributor Guide and Code of Conduct.
• [ x ] You've included unit or integration tests for your change, where applicable.

var jsRef = await js.InvokeAsync<IJSInProcessObjectReference>("caches.open", "default");
// below line throws an exception without fix
jsRef.Dispose();

• [ x ] You've included inline docs for your change, where applicable.
• [ x ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Fixed JSImport attribute for call to "DotNet.jsCallDispatcher.disposeJSObjectReferenceById"

Fixes #48280

[ghost]

Thanks for your PR, @LostBeard. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[LostBeard]

@dotnet-policy-service agree

[MackinnonBuck]

Thanks for the contribution, @LostBeard!

Would you be able to add a test verifying that IJSInProcessObjectReference.Dispose() works correctly?

[LostBeard]

@MackinnonBuck I am not exactly sure how to do what you are asking. I have created a demonstration project for the bug and the fix in my repo BlazorIJSInProcessObjectReferenceDisposeBugTest

Please let me know if that does not satisfy your request. I love Blazor and I am glad to help.

[MackinnonBuck]

@LostBeard thanks for verifying your fix 🙂 Apologies for not being clearer - we have some automated end-to-end tests in this repository, and I was thinking a great additional test case would be verifying that JSInProcessObjectReference instances can be disposed from .NET.

Don't worry about adding those tests - I'm happy to do that.

Also, there are currently some big changes happening in this area (see #48294), so it might be best that this PR gets finalized after that PR gets merged. For example, DotNet.jsCallDispatcher is getting removed, so this fix would get immediately broken after that PR merges.

I'll keep this PR up to date with whatever changes happen elsewhere. Thanks again for your contribution!

[MackinnonBuck]

/backport to release/8.0-preview5

[ghost]

Hi @MackinnonBuck. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

[github-actions]

Started backporting to release/8.0-preview5: https://github.com/dotnet/aspnetcore/actions/runs/5125101593