Add infrastructure for trimming and NativeAOT test apps. #48024
Conversation
This infrastructure was taken from https://github.com/dotnet/runtime/tree/c62f69be1405a8e41b56ffc05f22d791bf4c7d2d/eng/testing/linker and modified to work in dotnet/aspnetcore. Added the first test: - Generic host + value type container builder (verify that error is thrown) Contributes to dotnet#45860
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
...ultBuilder/test/Microsoft.AspNetCore.NativeAotTests/Microsoft.AspNetCore.NativeAotTests.proj
Outdated
Show resolved
Hide resolved
Use `Sdk="Microsoft.NET.Sdk"` and hook into CoreBuild for the published app test projects in order to skip the build correctly.
Ensure the IsPublishedAppTestProject projects aren't built until the shared fx is built.
Skip "Build" and skip pubilshing for Helix.
eerhardt
requested review from
Tratcher,
halter73,
a team and
wtgodbe
as code owners
|
So if I am reading this correctly, we basically have a set of console apps/ASP.NET apps in a single source file that we generate a project for, then publish (with AOT) and run them. And the return code from the program when it exits indicates success or failure? |
💯 percent correct. |
| Reference the Microsoft.AspNetCore.App shared framework assemblies with ProjectReference. | ||
| This allows for easy dev workflow. Just need to update the product code, and re-run the tests. | ||
| --> | ||
| <ItemGroup> |
There was a problem hiding this comment.
It works, but it is a bit heavier than this approach.
For example, the "incremental" run of .\.dotnet\dotnet.exe test .\src\DefaultBuilder\test\Microsoft.AspNetCore.NativeAotTests\ takes ~15s using app.ref and takes ~10s with this approach.
We can always switch this as we go forward if we need to. But for now I'd rather do the minimal.
ghost
added this to the 
This infrastructure was taken from https://github.com/dotnet/runtime/tree/c62f69be1405a8e41b56ffc05f22d791bf4c7d2d/eng/testing/linker and modified to work in dotnet/aspnetcore.
Added the first test:
Contributes to #45860
It is probably easiest to compare the files in
eng/testing/linkerto the files in dotnet/runtime to see what I changed. I can prepare that in a repo if people want. Or just use Beyond Compare (or similar) to diff between the two repos.Working on hooking this into CI now.