Write log message for matched fallback routes #47798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
mgravell,
mitchdenny,
Tratcher,
captainsafia,
BrennanConroy and
amcasey
mitchdenny
reviewed
Apr 20, 2023
src/Http/Routing/test/UnitTests/Builder/FallbackEndpointRouteBuilderExtensionsTest.cs
Show resolved
Hide resolved
mitchdenny
reviewed
Apr 20, 2023
|
LGTM other than a few minor comments. |
mitchdenny
approved these changes
Apr 20, 2023
Tratcher
approved these changes
Apr 20, 2023
javiercn
approved these changes
Apr 20, 2023
Co-authored-by: Chris Ross <Tratcher@Outlook.com>
ghost
added this to the 
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #46404
Fallback endpoints now have fallback metadata to identify them. Routing uses the metadata to decide whether to write a log message that a fallback route was used.
Fallback metadata could be made public in the future if there is a reason, but for now, it can be internal.