-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default configuration and logging to CreateSlimBuilder #47797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update slim builder to include: - JSON file configuration for appsettings.json and appsettings.{EnvironmentName}.json - UserSecrets configuration - Console logging - Logging configuration This adds back some app size to the api template app. But it is worth the tradeoff given users expect these things to work out of the box. Fix dotnet#47598
dotnet-issue-labeler
bot
added
the
area-mvc
Includes: MVC, Actions and Controllers, Localization, CORS, most templates
label
Apr 20, 2023
captainsafia
approved these changes
Apr 20, 2023
src/ProjectTemplates/Web.ProjectTemplates/content/Api-CSharp/appsettings.json
Show resolved
Hide resolved
DamianEdwards
previously requested changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one line to remove in appsettings.json
JamesNK
approved these changes
Apr 22, 2023
ghost
added this to the 8.0-preview4 milestone
Apr 24, 2023
AdisonCavani
added a commit
to AdisonCavani/todo-list
that referenced
this pull request
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default configuration and logging to CreateSlimBuilder
Update slim builder to include:
This adds back some app size to the api template app. But it is worth the tradeoff given users expect these things to work out of the box.
Update api template with appsettings files and remove AddConsole
Fix #47598