Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default configuration and logging to CreateSlimBuilder #47797

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

eerhardt
Copy link
Member

Add default configuration and logging to CreateSlimBuilder

Update slim builder to include:

  • JSON file configuration for appsettings.json and appsettings.{EnvironmentName}.json
  • UserSecrets configuration
  • Console logging
  • Logging configuration

This adds back some app size to the api template app. But it is worth the tradeoff given users expect these things to work out of the box.

Update api template with appsettings files and remove AddConsole

Fix #47598

 Update slim builder to include:
- JSON file configuration for appsettings.json and appsettings.{EnvironmentName}.json
- UserSecrets configuration
- Console logging
- Logging configuration

This adds back some app size to the api template app. But it is worth the tradeoff given users expect these things to work out of the box.

Fix dotnet#47598
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 20, 2023
Copy link
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one line to remove in appsettings.json

@eerhardt eerhardt dismissed DamianEdwards’s stale review April 22, 2023 20:39

Addressed comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
5 participants