Workaround problems when opening solution files in Visual Studio #4569
Conversation
* Workaround NU1105 by adding all ProjectReferences to the .sln * Workaround exceptions in the ReferencesHostBridge by moving Reference items to a temporary item group * Add a 'startvs.cmd' script for launching VS with the right env variables * Remove RangeHelper test project * Move RangeHelper tests into StaticFiles.Tests and add target for NPM restore
|
I don't think we need the NU1105 sln workaround, I have the build working locally without it. I'll follow up with @JamesNK. |
| @@ -135,7 +135,7 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Cors", | |||
| EndProject | |||
There was a problem hiding this comment.
We should remove the middleware.sln. It's already large enough that VS is having trouble loading it. It's also not useful as none of these projects reference eachother or are worked on together. Each middleware is it's own feature area and could have its own sln.
There was a problem hiding this comment.
Can we treat this as a separate issue?
|
@JamesNK wasn't able to get it working following the same steps I used, not sure why. We can try the sln workaround. |
|
|
||
| 1. Executing the following on command-line: | ||
| ``` | ||
| .\build.cmd /p:SkipTests=true /p:_ProjectsOnly=true |
There was a problem hiding this comment.
/p:BuildNumberSuffix=t9999, or have you addressed that another way?
There was a problem hiding this comment.
/p:BuildNumberSuffix=t9999 is only necessary in the master branch, but should be resolved by #4311. I'll add that to docs when I merge this up thru 2.2 and master.
|
I tried out building in the |
|
Which solution? |
|
Ah, right: |
|
Yeah, I see that now too. I'll add that to the .sln in my next PR. It seems NU1105 may not appear if you have already restored the projects. |
* Workaround problems when opening solution files in Visual Studio (#4569) Changes: * Condense Routing.sln into HttpAbstractions.sln * Workaround NU1105 by adding all ProjectReferences to the .sln * Workaround exceptions in the ReferencesHostBridge by moving Reference items to a temporary item group * Add a 'startvs.cmd' script for launching VS with the right env variables * Remove RangeHelper test project * Move RangeHelper tests into StaticFiles.Tests and add target for NPM restore * Convert Session to use Reference and move to Middleware folder (#4576) * Add RoutingSample.Web to HttpAbstractions.sln
Project reorganization and refactoring has led to a number of problems when opening .sln files. These changes are meant to mitigate issues in using Visual Studio.
Changes: