Skip to content

Conversation

@val1984
Copy link

@val1984 val1984 commented Nov 7, 2022

Change X-Requested-With header to "Fetch" in FetchHttpClient

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Change X-Requested-With header to "Fetch" from "XmlHttpRequest" in FetchHttpClient

Description

In its initial version, FetchHttpClient used to set X-Requested-With header to "Fetch" but it was changed in a later commit and it currently sets it as "XmlHttpRequest" which makes it harder to know which client is really used.

Fixes #44933

@ghost ghost added area-signalr Includes: SignalR clients and servers community-contribution Indicates that the PR has been added by a community member labels Nov 7, 2022
@ghost
Copy link

ghost commented Nov 7, 2022

Thanks for your PR, @val1984. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@BrennanConroy
Copy link
Member

Please file an issue/make sure there is an issue before making a PR so that potential changes can be discussed first.
https://github.com/dotnet/aspnetcore/blob/main/CONTRIBUTING.md#before-submitting-the-pull-request

@val1984
Copy link
Author

val1984 commented Nov 7, 2022

Please file an issue/make sure there is an issue before making a PR so that potential changes can be discussed first. https://github.com/dotnet/aspnetcore/blob/main/CONTRIBUTING.md#before-submitting-the-pull-request

@BrennanConroy Thank you for the reply. I created issue #44933

@BrennanConroy
Copy link
Member

Closing as the conversation in #44933 didn't convince us of the need for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-signalr Includes: SignalR clients and servers community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

X-Requested-With header is incorrect in FetchHttpClient

4 participants