Dispose httpclient in IIS tests #41283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
davidfowl
approved these changes
Apr 22, 2022
Member
Author
|
Looks pretty good for our super slow long tests, the shutdown/startup tests (19 minutes => 11 minutes) Before: After: |
HaoK
requested review from
BrennanConroy,
JamesNK,
Tratcher and
halter73
as code owners
Member
Author
|
This set of tests seem stable with the new pattern |
Tratcher
approved these changes
Jul 7, 2022
Member
Tratcher
left a comment
Tratcher
left a comment
There was a problem hiding this comment.
The only part of this that bothers me is that I'm pretty sure this delay is caused by a regression in IIS that we haven't been able to track down.
Member
Author
|
I can reopen/open a new issue to track that separately if you want? |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #41281
Just did GlobalVersionTests to start, if this pattern looks good I'll update the rest of the tests, roughly takes half as much time for tests that are hitting this
Before
After
cc @davidfowl in case we want to disable connection pooling instead