Friendlier exception when invoking JS from outside a WebView context #40943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
TanayParikh
approved these changes
Mar 29, 2022
|
Great! |
javiercn
approved these changes
Mar 30, 2022
|
Do we want to backport this to 6.0 @dotnet/dotnet-maui-blazor-eng? |
|
@TanayParikh I would say no. It hasn't come up all that much. If we see otherwise we could consider it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friendlier exception when invoking JS from outside a WebView context
Attempting to invoke JS from outside a WebView context (e.g. calling
IJSRuntimemethods in aWPForWinFormsapplication outside a Razor component) previously resulted in aNullReferenceExceptiongetting thrown. This PR throws a different exception that helps the developer understand that what they're attempting to do is not allowed.Fixes dotnet/maui#1245