Fix root directory not being considered by UseSolutionRelativeContentRoot() #34079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the root directory of a drive not being considered to find the solution. Addresses dotnet#33363.
Resolve CA1309 warning be specifying StringComparison.Ordinal.
ghost
added
area-runtime
community-contribution
davidfowl
reviewed
Jul 6, 2021
| @@ -86,7 +86,7 @@ public static IWebHostBuilder ConfigureTestServices(this IWebHostBuilder webHost | |||
| throw new ArgumentNullException(nameof(servicesConfiguration)); | |||
| } | |||
|
|
|||
| if (webHostBuilder.GetType().Name.Equals("GenericWebHostBuilder")) | |||
| if (webHostBuilder.GetType().Name.Equals("GenericWebHostBuilder", StringComparison.Ordinal)) | |||
There was a problem hiding this comment.
Sorry for drawing attention to it 😆
Tratcher
approved these changes
Jul 6, 2021
|
Thanks |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Fix root directory not being used by
UseSolutionRelativeContentRootPR Description
StringComparison.Ordinal.As noted in the original issue, this requires a specific file layout on disk and the code doesn't support using a mock file system, so there is no new unit test associated with the fix.
Addresses #33363