Skip to content

[release/5.0] Clean out Ubuntu 16.04 testing #33103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 1, 2021
Merged

[release/5.0] Clean out Ubuntu 16.04 testing #33103

merged 4 commits into from
Jun 1, 2021

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented May 28, 2021 •
edited
Loading

  • Clean out Ubuntu 16.04 testing
  • Update cert that became valid and broke tests
  • Update Chrome driver
  • Update selenium chrome driver

dougbu and others added 4 commits May 27, 2021 16:27
@dougbu
[release/5.0] Clean out Ubuntu 16.04 testing
dde7ea6 
- cherry-pick of #32894

* Clean out Ubuntu 16.04 testing
  - use Ubuntu 18.04 agents for testing in Docker containers on Helix
  - also move to supported version of Fedora

* Support added `msbuild` arguments in RunHelix.ps1
  - bring in part of 0551cef (#32554)
  - no reason to maintain major differences from main version of script
    - slight difference is we still test on Windows.10.Amd64.Open by default here

nits:
- clean up a few old mentions of Centos and Fedora testing
- fix `%(Platform)` metadata for OSX `@(HelixAvailableTargetQueue)` items
- pick up a small bit of the master -> main renaming improvements
- use `[switch]` instead of `[bool]` in RunHelix.ps1 parameters
@HaoK @dougbu
[release/5.0] Update cert that became valid and broke tests
ea3a504 
- backport of 2e20bab (#32812)
- dupe of #33033

* Update cert to not be valid for 50 years

* Make cert valid in 10 years

* Delete unused copy of certs, update right one

* Skip test for now
@BrennanConroy @dougbu
[release/5.0] Update Chrome driver
af42e20 
- backport of e7b5aa6 (#33019)
@BrennanConroy @dougbu
[release/5.0] Update selenium chrome driver
b8f1156 
- backport of af96aba (#33043)
@dougbu dougbu changed the base branch from main to release/5.0 May 28, 2021 05:17
@dougbu
Copy link
Contributor Author

dougbu commented May 28, 2021

@HaoK @BrennanConroy I'm duplicating #33033 and backporting both #33019 and #33043 here to see if the fixes are enough to get 5.0.x builds working again. I'll probably move the #33019 and #33043 commits into #33033 if this works because the Ubuntu 16.04 removal shouldn't be necessary to fix our builds. Plan is to merge the fixes for build breaks together w/ 5.0.8 branding and keep other bits separate.

@dotnet/aspnet-build this can be ignored for now but /fyi

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 28, 2021
@dougbu dougbu marked this pull request as ready for review May 29, 2021 04:57
@dougbu dougbu requested a review from Tratcher as a code owner May 29, 2021 04:57
@dougbu dougbu requested review from HaoK and a team May 29, 2021 04:58
@dougbu dougbu added the ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. label May 29, 2021
@dougbu
Copy link
Contributor Author

dougbu commented May 29, 2021

Note to reviewers: Only the first commit will go in separately (and after) #33033. That's all to review here.

@dougbu dougbu added this to the 5.0.8 milestone May 29, 2021
@dougbu dougbu added ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. tell-mode Indicates a PR which is being merged during tell-mode and removed ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. labels May 29, 2021
@dougbu dougbu changed the title [release/5.0] Get builds working [release/5.0] Clean out Ubuntu 16.04 testing May 29, 2021
@dougbu dougbu merged commit 18409d9 into release/5.0 Jun 1, 2021
@dougbu dougbu deleted the dougbu/quit.Ubuntu.16.04/5.0 branch June 1, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoK HaoK HaoK approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher Tratcher is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
5.0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@dougbu @HaoK @Pilchie @BrennanConroy