Skip to content

[SPA] Enable support for publish single file #13518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2019

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Aug 28, 2019

Description
SPA templates won't work with single file publish

Customer Impact
Customers won't be able to use single file publish with the SPA templates out of the box.

Regression?
No, PublishSingleFile is a new feature

Risk
Very low.

Customers can workaround the issue in the same way this PR does, but it offers a bad out of the box experience and the fix is trivial.

* Updates the angular template to exclude the client-side files from the single file publish output
* Excludes the client-side build output from the single file publish output
* Excludes the client-side files from the single file publish output.
@javiercn javiercn marked this pull request as ready for review August 28, 2019 16:42
@mkArtakMSFT mkArtakMSFT added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. labels Aug 28, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0 milestone Aug 28, 2019
@javiercn javiercn merged commit 14136e7 into release/3.0 Aug 29, 2019
@javiercn javiercn deleted the javiercn/spa-single-file-publish branch August 29, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants