rename

Author: BrennanConroy

src/SignalR/clients/csharp/Client.SourceGenerator/src/HubProxyAttributes/ClientHubAttribute.cs

@@ -0,0 +1,18 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using System;
+
+namespace Microsoft.AspNetCore.SignalR.Client;
+
+/// <summary>
+/// Provides information for generating strongly typed SignalR client callbacks.
+/// Place this attribute on a method with the following syntax:
+/// <code>
+///   public static partial IDisposable RegisterCallbacks&lt;T&gt;(this HubConnection connection, T proxy);
+/// </code>
+/// </summary>
+[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
+public sealed class ClientHubAttribute : Attribute
+{
+}

src/SignalR/clients/csharp/Client.SourceGenerator/src/HubProxyAttributes/HubClientProxyAttribute.cs

@@ -1,4 +1,4 @@
-Microsoft.AspNetCore.SignalR.Client.HubClientProxyAttribute
-Microsoft.AspNetCore.SignalR.Client.HubClientProxyAttribute.HubClientProxyAttribute() -> void
-Microsoft.AspNetCore.SignalR.Client.HubServerProxyAttribute
-Microsoft.AspNetCore.SignalR.Client.HubServerProxyAttribute.HubServerProxyAttribute() -> void
+Microsoft.AspNetCore.SignalR.Client.ClientHubAttribute
+Microsoft.AspNetCore.SignalR.Client.ClientHubAttribute.ClientHubAttribute() -> void
+Microsoft.AspNetCore.SignalR.Client.ServerHubProxyAttribute
+Microsoft.AspNetCore.SignalR.Client.ServerHubProxyAttribute.ServerHubProxyAttribute() -> void

src/SignalR/clients/csharp/Client.SourceGenerator/src/HubProxyAttributes/HubServerProxyAttribute.cs

@@ -0,0 +1,18 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using System;
+
+namespace Microsoft.AspNetCore.SignalR.Client;
+
+/// <summary>
+/// Provides information for generating strongly typed SignalR server invocations from the client.
+/// Place this attribute on a method with the following syntax:
+/// <code>
+///   public static partial T GetProxy&lt;T&gt;(this HubConnection connection);
+/// </code>
+/// </summary>
+[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
+public sealed class ServerHubProxyAttribute : Attribute
+{
+}

src/SignalR/clients/csharp/Client.SourceGenerator/src/HubProxyAttributes/PublicAPI.Unshipped.txt

@@ -7,7 +7,7 @@
 
 namespace Microsoft.AspNetCore.SignalR.Client.SourceGenerator;
 
-internal partial class HubClientProxyGenerator
+internal partial class ClientHubGenerator
 {
     public class Emitter
     {

src/SignalR/clients/csharp/Client.SourceGenerator/src/HubProxyAttributes/ServerHubProxyAttribute.cs

@@ -11,7 +11,7 @@
 
 namespace Microsoft.AspNetCore.SignalR.Client.SourceGenerator;
 
-internal partial class HubClientProxyGenerator
+internal partial class ClientHubGenerator
 {
     public class Parser
     {
@@ -21,7 +21,7 @@ internal static bool IsSyntaxTargetForAttribute(SyntaxNode node) => node is Attr
             {
                 Identifier:
                 {
-                    Text: "HubClientProxy"
+                    Text: "ClientHub"
                 }
             },
             Parent:
@@ -39,7 +39,7 @@ internal static bool IsSyntaxTargetForAttribute(SyntaxNode node) => node is Attr
             var attributeSymbol = ModelExtensions.GetSymbolInfo(context.SemanticModel, attributeSyntax).Symbol;
 
             if (attributeSymbol is null ||
-                !attributeSymbol.ToString().EndsWith("HubClientProxyAttribute()", StringComparison.Ordinal))
+                !attributeSymbol.ToString().EndsWith("ClientHubAttribute()", StringComparison.Ordinal))
             {
                 return null;
             }
@@ -53,7 +53,7 @@ private static bool IsExtensionMethodSignatureValid(IMethodSymbol symbol, Source
             if (!symbol.IsPartialDefinition)
             {
                 context.ReportDiagnostic(Diagnostic.Create(
-                    DiagnosticDescriptors.HubClientProxyAttributedMethodIsNotPartial,
+                    DiagnosticDescriptors.ClientHubAttributedMethodIsNotPartial,
                     symbol.Locations[0]));
                 return false;
             }
@@ -62,7 +62,7 @@ private static bool IsExtensionMethodSignatureValid(IMethodSymbol symbol, Source
             if (!symbol.IsExtensionMethod)
             {
                 context.ReportDiagnostic(Diagnostic.Create(
-                    DiagnosticDescriptors.HubClientProxyAttributedMethodIsNotExtension,
+                    DiagnosticDescriptors.ClientHubAttributedMethodIsNotExtension,
                     symbol.Locations[0]));
                 return false;
             }
@@ -71,7 +71,7 @@ private static bool IsExtensionMethodSignatureValid(IMethodSymbol symbol, Source
             if (symbol.Arity != 1)
             {
                 context.ReportDiagnostic(Diagnostic.Create(
-                    DiagnosticDescriptors.HubClientProxyAttributedMethodTypeArgCountIsBad,
+                    DiagnosticDescriptors.ClientHubAttributedMethodTypeArgCountIsBad,
                     symbol.Locations[0]));
                 return false;
             }
@@ -80,7 +80,7 @@ private static bool IsExtensionMethodSignatureValid(IMethodSymbol symbol, Source
             if (symbol.Parameters.Length != 2)
             {
                 context.ReportDiagnostic(Diagnostic.Create(
-                    DiagnosticDescriptors.HubClientProxyAttributedMethodArgCountIsBad,
+                    DiagnosticDescriptors.ClientHubAttributedMethodArgCountIsBad,
                     symbol.Locations[0]));
                 return false;
             }
@@ -89,7 +89,7 @@ private static bool IsExtensionMethodSignatureValid(IMethodSymbol symbol, Source
             if (!SymbolEqualityComparer.Default.Equals(symbol.TypeArguments[0], symbol.Parameters[1].Type))
             {
                 context.ReportDiagnostic(Diagnostic.Create(
-                    DiagnosticDescriptors.HubClientProxyAttributedMethodTypeArgAndProviderTypeDoesNotMatch,
+                    DiagnosticDescriptors.ClientHubAttributedMethodTypeArgAndProviderTypeDoesNotMatch,
                     symbol.Locations[0]));
                 return false;
             }
@@ -98,7 +98,7 @@ private static bool IsExtensionMethodSignatureValid(IMethodSymbol symbol, Source
             if (symbol.ReturnType.ToString() != "System.IDisposable")
             {
                 context.ReportDiagnostic(Diagnostic.Create(
-                    DiagnosticDescriptors.HubClientProxyAttributedMethodHasBadReturnType,
+                    DiagnosticDescriptors.ClientHubAttributedMethodHasBadReturnType,
                     symbol.Locations[0]));
                 return false;
             }
@@ -107,7 +107,7 @@ private static bool IsExtensionMethodSignatureValid(IMethodSymbol symbol, Source
             if (hubConnectionSymbol.ToString() != "Microsoft.AspNetCore.SignalR.Client.HubConnection")
             {
                 context.ReportDiagnostic(Diagnostic.Create(
-                    DiagnosticDescriptors.HubClientProxyAttributedMethodArgIsNotHubConnection,
+                    DiagnosticDescriptors.ClientHubAttributedMethodArgIsNotHubConnection,
                     symbol.Locations[0]));
                 return false;
             }
@@ -160,7 +160,7 @@ internal static bool IsSyntaxTargetForGeneration(SyntaxNode node) => node is Mem
             foreach (var attributeData in methodSymbol.GetAttributes())
             {
                 if (!attributeData.AttributeClass.ToString()
-                    .EndsWith("HubClientProxyAttribute", StringComparison.Ordinal))
+                    .EndsWith("ClientHubAttribute", StringComparison.Ordinal))
                 {
                     continue;
                 }
@@ -195,7 +195,7 @@ internal SourceGenerationSpec Parse(ImmutableArray<MethodDeclarationSyntax> meth
                 {
                     _context.ReportDiagnostic(
                         Diagnostic.Create(
-                            DiagnosticDescriptors.TooManyHubClientProxyAttributedMethods,
+                            DiagnosticDescriptors.TooManyClientHubAttributedMethods,
                             extraneous.GetLocation()));
                 }
 
@@ -226,7 +226,7 @@ internal SourceGenerationSpec Parse(ImmutableArray<MethodDeclarationSyntax> meth
             if (sourceGenerationSpec.SetterMethodAccessibility is null)
             {
                 _context.ReportDiagnostic(Diagnostic.Create(
-                    DiagnosticDescriptors.HubClientProxyAttributedMethodBadAccessibility,
+                    DiagnosticDescriptors.ClientHubAttributedMethodBadAccessibility,
                     methodDeclarationSyntax.GetLocation()));
                 return sourceGenerationSpec;
             }
@@ -301,7 +301,7 @@ internal SourceGenerationSpec Parse(ImmutableArray<MethodDeclarationSyntax> meth
                     if (!(member.ReturnsVoid || member.ReturnType is INamedTypeSymbol { Arity: 0, Name: "Task" }))
                     {
                         _context.ReportDiagnostic(Diagnostic.Create(
-                            DiagnosticDescriptors.HubClientProxyUnsupportedReturnType,
+                            DiagnosticDescriptors.ClientHubUnsupportedReturnType,
                             typeSpec.CallSite,
                             methodSpec.Name, member.ReturnType.Name));
                         methodSpec.Support = SupportClassification.UnsupportedReturnType;

src/SignalR/clients/csharp/Client.SourceGenerator/src/gen/HubClientProxyGenerator.Emitter.cs renamed to src/SignalR/clients/csharp/Client.SourceGenerator/src/gen/ClientHubGenerator.Emitter.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.SignalR.Client.SourceGenerator;
 
-internal partial class HubClientProxyGenerator
+internal partial class ClientHubGenerator
 {
     public class SourceGenerationSpec
     {

src/SignalR/clients/csharp/Client.SourceGenerator/src/gen/HubClientProxyGenerator.Parser.cs renamed to src/SignalR/clients/csharp/Client.SourceGenerator/src/gen/ClientHubGenerator.Parser.cs

@@ -8,7 +8,7 @@
 namespace Microsoft.AspNetCore.SignalR.Client.SourceGenerator;
 
 [Generator]
-internal partial class HubServerProxyGenerator : IIncrementalGenerator
+internal partial class ClientHubGenerator : IIncrementalGenerator
 {
     public void Initialize(IncrementalGeneratorInitializationContext context)
     {