React to EF changes

Author: AndriySvyryd

src/Middleware/Diagnostics.EntityFrameworkCore/src/HttpContextDatabaseContextDetailsExtensions.cs

@@ -45,11 +45,6 @@ internal static class HttpContextDatabaseContextDetailsExtensions
 
         var snapshotModel = migrationsAssembly.ModelSnapshot?.Model;
 
-        if (snapshotModel is IMutableModel mutableModel)
-        {
-            snapshotModel = mutableModel.FinalizeModel();
-        }
-
         if (snapshotModel != null)
         {
             snapshotModel = context.GetService<IModelRuntimeInitializer>().Initialize(snapshotModel);

src/Middleware/Diagnostics.EntityFrameworkCore/test/FunctionalTests/DatabaseErrorPageMiddlewareTest.cs

@@ -15,6 +15,7 @@
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
+using Microsoft.EntityFrameworkCore.Diagnostics;
 
 namespace Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests;
 
@@ -538,7 +539,9 @@ private static async Task<IHost> SetupServer<TContext, TMiddleware>(SqlTestStore
                 })
                 .ConfigureServices(services =>
                 {
-                    services.AddDbContext<TContext>(optionsBuilder => optionsBuilder.UseSqlite(database.ConnectionString));
+                    services.AddDbContext<TContext>(optionsBuilder => optionsBuilder
+                        .UseSqlite(database.ConnectionString)
+                        .ConfigureWarnings(w => w.Log(RelationalEventId.PendingModelChangesWarning)));
                 });
             }).Build();
 

src/Middleware/Diagnostics.EntityFrameworkCore/test/FunctionalTests/MigrationsEndPointMiddlewareTest.cs

@@ -262,7 +262,7 @@ public async Task Exception_while_applying_migrations()
                 await server.CreateClient().PostAsync("http://localhost" + MigrationsEndPointOptions.DefaultPath, formData));
 
             Assert.StartsWith(StringsHelpers.GetResourceString("FormatMigrationsEndPointMiddleware_Exception", typeof(BloggingContextWithSnapshotThatThrows)), ex.Message);
-            Assert.Equal("Welcome to the invalid migration!", ex.InnerException.Message);
+            Assert.Equal("Welcome to the invalid snapshot!", ex.InnerException.Message);
         }
     }
 }

src/Middleware/Diagnostics.EntityFrameworkCore/test/FunctionalTests/TestModels/BloggingContextWithMigrations.cs

@@ -26,6 +26,7 @@ private static void BuildSnapshotModel(ModelBuilder builder)
             b.Property<int>("BlogId").ValueGeneratedOnAdd();
             b.Property<string>("Name");
             b.HasKey("BlogId");
+            b.ToTable("Blogs");
         });
     }