Skip to content

Commit 8869208

Browse files
committed
fixup
1 parent 8c3f586 commit 8869208

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

src/Hosting/Hosting/test/Microsoft.AspNetCore.Hosting.Tests.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
<PropertyGroup>
44
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
55
<!-- EXTEXP0003: MetricCollector is experimental -->
6-
<!-- CS0618: WebHostBuilder is obsolete -->
7-
<NoWarn>$(NoWarn);EXTEXP0003;CS0618</NoWarn>
6+
<NoWarn>$(NoWarn);EXTEXP0003</NoWarn>
87
</PropertyGroup>
98

109
<ItemGroup>

src/Hosting/Hosting/test/WebHostBuilderTests.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,7 @@ public void DoNotCaptureStartupErrorsByDefault(IWebHostBuilder builder)
429429
public void ServiceProviderDisposedOnBuildException()
430430
{
431431
var service = new DisposableService();
432+
#pragma warning disable CS0618 // Type or member is obsolete
432433
var hostBuilder = new WebHostBuilder()
433434
.UseServer(new TestServer())
434435
.ConfigureServices(services =>
@@ -437,6 +438,7 @@ public void ServiceProviderDisposedOnBuildException()
437438
services.AddSingleton(sp => service);
438439
})
439440
.UseStartup<StartupWithResolvedDisposableThatThrows>();
441+
#pragma warning restore CS0618 // Type or member is obsolete
440442

441443
Assert.Throws<InvalidOperationException>(() => hostBuilder.Build());
442444
Assert.True(service.Disposed);
@@ -1483,14 +1485,18 @@ private IWebHostBuilder CreateWebHostBuilder()
14831485
.AddInMemoryCollection(vals);
14841486
var config = builder.Build();
14851487

1488+
#pragma warning disable CS0618 // Type or member is obsolete
14861489
return new WebHostBuilder().UseConfiguration(config);
1490+
#pragma warning restore CS0618 // Type or member is obsolete
14871491
}
14881492

1493+
#pragma warning disable CS0618 // Type or member is obsolete
14891494
public static TheoryData<IWebHostBuilder> DefaultWebHostBuilders => new TheoryData<IWebHostBuilder>
14901495
{
14911496
new WebHostBuilder(),
14921497
new GenericWebHostBuilderWrapper(new HostBuilder())
14931498
};
1499+
#pragma warning restore CS0618 // Type or member is obsolete
14941500

14951501
public static TheoryData<IWebHostBuilder> DefaultWebHostBuildersWithConfig
14961502
{
@@ -1506,10 +1512,12 @@ public static TheoryData<IWebHostBuilder> DefaultWebHostBuildersWithConfig
15061512
.AddInMemoryCollection(vals);
15071513
var config = builder.Build();
15081514

1515+
#pragma warning disable CS0618 // Type or member is obsolete
15091516
return new TheoryData<IWebHostBuilder> {
15101517
new WebHostBuilder().UseConfiguration(config),
15111518
new GenericWebHostBuilderWrapper(new HostBuilder()).UseConfiguration(config)
15121519
};
1520+
#pragma warning restore CS0618 // Type or member is obsolete
15131521
}
15141522
}
15151523

@@ -1783,3 +1791,4 @@ public void Dispose()
17831791
public void AddProvider(ILoggerProvider provider) { }
17841792
}
17851793
}
1794+
//#pragma warning restore CS0618 // Type or member is obsolete

src/Hosting/Hosting/test/WebHostTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1103,7 +1103,9 @@ private IWebHost CreateHost(RequestDelegate requestDelegate)
11031103

11041104
private IWebHostBuilder CreateBuilder(IConfiguration config = null)
11051105
{
1106+
#pragma warning disable CS0618 // Type or member is obsolete
11061107
return new WebHostBuilder().UseConfiguration(config ?? new ConfigurationBuilder().Build()).UseStartup("Microsoft.AspNetCore.Hosting.Tests");
1108+
#pragma warning restore CS0618 // Type or member is obsolete
11071109
}
11081110

11091111
private static bool[] RegisterCallbacksThatThrow(IServiceCollection services)

src/Servers/testassets/ServerComparison.TestSites/Program.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
using Microsoft.AspNetCore.Hosting;
66
using Microsoft.AspNetCore.Server.HttpSys;
77
using Microsoft.Extensions.Configuration;
8+
using Microsoft.Extensions.Hosting;
89
using Microsoft.Extensions.Logging;
910

1011
namespace ServerComparison.TestSites;
@@ -18,7 +19,6 @@ public static void Main(string[] args)
1819
.Build();
1920

2021
var builder = new HostBuilder()
21-
.UseConfiguration(configuration)
2222
.ConfigureLogging((_, factory) =>
2323
{
2424
factory.AddConsole();
@@ -27,6 +27,7 @@ public static void Main(string[] args)
2727
.ConfigureWebHost(webHostBuilder =>
2828
{
2929
webHostBuilder
30+
.UseConfiguration(configuration)
3031
.UseStartup("ServerComparison.TestSites")
3132
.UseKestrel()
3233
.UseIISIntegration()

0 commit comments

Comments
 (0)