Skip to content

Commit 87769fc

Browse files
Avoid using invalid content type for ValidationProblemDetails (#36618)
Co-authored-by: Safia Abdalla <safia@microsoft.com>
1 parent b16aa3d commit 87769fc

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/Http/Routing/src/Builder/OpenApiDelegateEndpointConventionBuilderExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,15 @@ public static DelegateEndpointConventionBuilder ProducesProblem(this DelegateEnd
109109
/// </summary>
110110
/// <param name="builder">The <see cref="DelegateEndpointConventionBuilder"/>.</param>
111111
/// <param name="statusCode">The response status code. Defaults to StatusCodes.Status400BadRequest.</param>
112-
/// <param name="contentType">The response content type. Defaults to "application/validationproblem+json".</param>
112+
/// <param name="contentType">The response content type. Defaults to "application/problem+json".</param>
113113
/// <returns>A <see cref="DelegateEndpointConventionBuilder"/> that can be used to further customize the endpoint.</returns>
114114
public static DelegateEndpointConventionBuilder ProducesValidationProblem(this DelegateEndpointConventionBuilder builder,
115115
int statusCode = StatusCodes.Status400BadRequest,
116116
string? contentType = null)
117117
{
118118
if (string.IsNullOrEmpty(contentType))
119119
{
120-
contentType = "application/validationproblem+json";
120+
contentType = "application/problem+json";
121121
}
122122

123123
return Produces<HttpValidationProblemDetails>(builder, statusCode, contentType);

src/Mvc/Mvc.ApiExplorer/test/ApiResponseTypeProviderTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -715,7 +715,7 @@ public void GetApiResponseTypes_HandlesActionWithMultipleContentTypesAndProduces
715715
// Arrange
716716
var actionDescriptor = GetControllerActionDescriptor(typeof(TestController), nameof(TestController.GetUser));
717717
actionDescriptor.FilterDescriptors.Add(new FilterDescriptor(new ProducesAttribute("text/xml") { Type = typeof(BaseModel) }, FilterScope.Action));
718-
actionDescriptor.FilterDescriptors.Add(new FilterDescriptor(new ProducesResponseTypeAttribute(typeof(ValidationProblemDetails), 400, "application/validationproblem+json"), FilterScope.Action));
718+
actionDescriptor.FilterDescriptors.Add(new FilterDescriptor(new ProducesResponseTypeAttribute(typeof(ValidationProblemDetails), 400, "application/problem+json"), FilterScope.Action));
719719
actionDescriptor.FilterDescriptors.Add(new FilterDescriptor(new ProducesResponseTypeAttribute(typeof(ProblemDetails), 404, "application/problem+json"), FilterScope.Action));
720720
actionDescriptor.FilterDescriptors.Add(new FilterDescriptor(new ProducesResponseTypeAttribute(409), FilterScope.Action));
721721

@@ -738,7 +738,7 @@ public void GetApiResponseTypes_HandlesActionWithMultipleContentTypesAndProduces
738738
{
739739
Assert.Equal(typeof(ValidationProblemDetails), responseType.Type);
740740
Assert.Equal(400, responseType.StatusCode);
741-
Assert.Equal(new[] { "application/validationproblem+json" }, GetSortedMediaTypes(responseType));
741+
Assert.Equal(new[] { "application/problem+json" }, GetSortedMediaTypes(responseType));
742742
},
743743
responseType =>
744744
{

src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,7 +603,7 @@ public void HandlesProducesWithProducesProblem()
603603
{
604604
Assert.Equal(typeof(HttpValidationProblemDetails), responseType.Type);
605605
Assert.Equal(400, responseType.StatusCode);
606-
Assert.Equal(new[] { "application/validationproblem+json" }, GetSortedMediaTypes(responseType));
606+
Assert.Equal(new[] { "application/problem+json" }, GetSortedMediaTypes(responseType));
607607
},
608608
responseType =>
609609
{

0 commit comments

Comments
 (0)