React to "Shrink StringValues" (#8864)

benaadams · davidfowl · commit 77380fb27b22 · 2019-04-05T12:12:08.000-07:00
diff --git a/src/Servers/Kestrel/Core/src/BadHttpRequestException.cs b/src/Servers/Kestrel/Core/src/BadHttpRequestException.cs
@@ -128,7 +128,7 @@ internal static void Throw(RequestRejectionReason reason, string detail)
         }
 
         [StackTraceHidden]
-        internal static void Throw(RequestRejectionReason reason, in StringValues detail)
+        internal static void Throw(RequestRejectionReason reason, StringValues detail)
         {
             throw GetException(reason, detail.ToString());
         }
diff --git a/src/Servers/Kestrel/Core/src/Internal/Http/Http1MessageBody.cs b/src/Servers/Kestrel/Core/src/Internal/Http/Http1MessageBody.cs
@@ -145,7 +145,7 @@ public static MessageBody For(
                 // status code and then close the connection.
                 if (transferCoding != TransferCoding.Chunked)
                 {
-                    BadHttpRequestException.Throw(RequestRejectionReason.FinalTransferCodingNotChunked, in transferEncoding);
+                    BadHttpRequestException.Throw(RequestRejectionReason.FinalTransferCodingNotChunked, transferEncoding);
                 }
 
                 // TODO may push more into the wrapper rather than just calling into the message body
diff --git a/src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.Generated.cs b/src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.Generated.cs
@@ -1258,7 +1258,7 @@ protected override bool TryGetValueFast(string key, out StringValues value)
             return MaybeUnknown?.TryGetValue(key, out value) ?? false;
         }
 
-        protected override void SetValueFast(string key, in StringValues value)
+        protected override void SetValueFast(string key, StringValues value)
         {
             switch (key.Length)
             {
@@ -1606,7 +1606,7 @@ protected override void SetValueFast(string key, in StringValues value)
             SetValueUnknown(key, value);
         }
 
-        protected override bool AddValueFast(string key, in StringValues value)
+        protected override bool AddValueFast(string key, StringValues value)
         {
             switch (key.Length)
             {
@@ -5337,25 +5337,25 @@ public StringValues HeaderContentLength
             }
         }
 
-        public void SetRawConnection(in StringValues value, byte[] raw)
+        public void SetRawConnection(StringValues value, byte[] raw)
         {
             _bits |= 0x2L;
             _headers._Connection = value;
             _headers._rawConnection = raw;
         }
-        public void SetRawDate(in StringValues value, byte[] raw)
+        public void SetRawDate(StringValues value, byte[] raw)
         {
             _bits |= 0x4L;
             _headers._Date = value;
             _headers._rawDate = raw;
         }
-        public void SetRawTransferEncoding(in StringValues value, byte[] raw)
+        public void SetRawTransferEncoding(StringValues value, byte[] raw)
         {
             _bits |= 0x40L;
             _headers._TransferEncoding = value;
             _headers._rawTransferEncoding = raw;
         }
-        public void SetRawServer(in StringValues value, byte[] raw)
+        public void SetRawServer(StringValues value, byte[] raw)
         {
             _bits |= 0x2000000L;
             _headers._Server = value;
@@ -5776,7 +5776,7 @@ protected override bool TryGetValueFast(string key, out StringValues value)
             return MaybeUnknown?.TryGetValue(key, out value) ?? false;
         }
 
-        protected override void SetValueFast(string key, in StringValues value)
+        protected override void SetValueFast(string key, StringValues value)
         {
             ValidateHeaderValueCharacters(value);
             switch (key.Length)
@@ -6081,7 +6081,7 @@ protected override void SetValueFast(string key, in StringValues value)
             SetValueUnknown(key, value);
         }
 
-        protected override bool AddValueFast(string key, in StringValues value)
+        protected override bool AddValueFast(string key, StringValues value)
         {
             ValidateHeaderValueCharacters(value);
             switch (key.Length)
@@ -8589,7 +8589,7 @@ protected override bool TryGetValueFast(string key, out StringValues value)
             return MaybeUnknown?.TryGetValue(key, out value) ?? false;
         }
 
-        protected override void SetValueFast(string key, in StringValues value)
+        protected override void SetValueFast(string key, StringValues value)
         {
             ValidateHeaderValueCharacters(value);
             switch (key.Length)
@@ -8609,7 +8609,7 @@ protected override void SetValueFast(string key, in StringValues value)
             SetValueUnknown(key, value);
         }
 
-        protected override bool AddValueFast(string key, in StringValues value)
+        protected override bool AddValueFast(string key, StringValues value)
         {
             ValidateHeaderValueCharacters(value);
             switch (key.Length)
diff --git a/src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs b/src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs
@@ -121,7 +121,7 @@ public void Reset()
         }
 
         [MethodImpl(MethodImplOptions.NoInlining)]
-        protected static StringValues AppendValue(in StringValues existing, string append)
+        protected static StringValues AppendValue(StringValues existing, string append)
         {
             return StringValues.Concat(existing, append);
         }
@@ -157,10 +157,10 @@ protected virtual int GetCountFast()
         protected virtual bool TryGetValueFast(string key, out StringValues value)
         { throw new NotImplementedException(); }
 
-        protected virtual void SetValueFast(string key, in StringValues value)
+        protected virtual void SetValueFast(string key, StringValues value)
         { throw new NotImplementedException(); }
 
-        protected virtual bool AddValueFast(string key, in StringValues value)
+        protected virtual bool AddValueFast(string key, StringValues value)
         { throw new NotImplementedException(); }
 
         protected virtual bool RemoveFast(string key)
@@ -259,7 +259,7 @@ bool IDictionary<string, StringValues>.TryGetValue(string key, out StringValues
             return TryGetValueFast(key, out value);
         }
 
-        public static void ValidateHeaderValueCharacters(in StringValues headerValues)
+        public static void ValidateHeaderValueCharacters(StringValues headerValues)
         {
             var count = headerValues.Count;
             for (var i = 0; i < count; i++)
@@ -290,7 +290,7 @@ public static void ValidateHeaderNameCharacters(string headerCharacters)
             }
         }
 
-        public static unsafe ConnectionOptions ParseConnection(in StringValues connection)
+        public static unsafe ConnectionOptions ParseConnection(StringValues connection)
         {
             var connectionOptions = ConnectionOptions.None;
 
@@ -392,7 +392,7 @@ public static unsafe ConnectionOptions ParseConnection(in StringValues connectio
             return connectionOptions;
         }
 
-        public static unsafe TransferCoding GetFinalTransferCoding(in StringValues transferEncoding)
+        public static unsafe TransferCoding GetFinalTransferCoding(StringValues transferEncoding)
         {
             var transferEncodingOptions = TransferCoding.None;
 
diff --git a/src/Servers/Kestrel/Core/src/Internal/Http/HttpRequestHeaders.cs b/src/Servers/Kestrel/Core/src/Internal/Http/HttpRequestHeaders.cs
@@ -24,7 +24,7 @@ private static long ParseContentLength(string value)
         }
 
         [MethodImpl(MethodImplOptions.NoInlining)]
-        private void SetValueUnknown(string key, in StringValues value)
+        private void SetValueUnknown(string key, StringValues value)
         {
             Unknown[key] = value;
         }
diff --git a/src/Servers/Kestrel/Core/src/Internal/Http/HttpResponseHeaders.cs b/src/Servers/Kestrel/Core/src/Internal/Http/HttpResponseHeaders.cs
@@ -64,7 +64,7 @@ private static void ThrowInvalidContentLengthException(string value)
         }
 
         [MethodImpl(MethodImplOptions.NoInlining)]
-        private void SetValueUnknown(string key, in StringValues value)
+        private void SetValueUnknown(string key, StringValues value)
         {
             ValidateHeaderNameCharacters(key);
             Unknown[key] = value;
diff --git a/src/Servers/Kestrel/Core/src/Internal/Http/HttpResponseTrailers.cs b/src/Servers/Kestrel/Core/src/Internal/Http/HttpResponseTrailers.cs
@@ -22,7 +22,7 @@ protected override IEnumerator<KeyValuePair<string, StringValues>> GetEnumerator
         }
 
         [MethodImpl(MethodImplOptions.NoInlining)]
-        private void SetValueUnknown(string key, in StringValues value)
+        private void SetValueUnknown(string key, StringValues value)
         {
             ValidateHeaderNameCharacters(key);
             Unknown[key] = value;
diff --git a/src/Servers/Kestrel/tools/CodeGenerator/KnownHeaders.cs b/src/Servers/Kestrel/tools/CodeGenerator/KnownHeaders.cs
@@ -385,7 +385,7 @@ public StringValues Header{header.Identifier}
             }}")}
         }}")}
 {Each(loop.Headers.Where(header => header.EnhancedSetter), header => $@"
-        public void SetRaw{header.Identifier}(in StringValues value, byte[] raw)
+        public void SetRaw{header.Identifier}(StringValues value, byte[] raw)
         {{
             {header.SetBit()};
             _headers._{header.Identifier} = value;
@@ -425,7 +425,7 @@ protected override bool TryGetValueFast(string key, out StringValues value)
             return MaybeUnknown?.TryGetValue(key, out value) ?? false;
         }}
 
-        protected override void SetValueFast(string key, in StringValues value)
+        protected override void SetValueFast(string key, StringValues value)
         {{{(loop.ClassName != "HttpRequestHeaders" ? @"
             ValidateHeaderValueCharacters(value);" : "")}
             switch (key.Length)
@@ -447,7 +447,7 @@ protected override void SetValueFast(string key, in StringValues value)
             SetValueUnknown(key, value);
         }}
 
-        protected override bool AddValueFast(string key, in StringValues value)
+        protected override bool AddValueFast(string key, StringValues value)
         {{{(loop.ClassName != "HttpRequestHeaders" ? @"
             ValidateHeaderValueCharacters(value);" : "")}
             switch (key.Length)

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ internal static void Throw(RequestRejectionReason reason, string detail)`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`[StackTraceHidden]`
`131`		`- internal static void Throw(RequestRejectionReason reason, in StringValues detail)`
	`131`	`+ internal static void Throw(RequestRejectionReason reason, StringValues detail)`
`132`	`132`	`{`
`133`	`133`	`throw GetException(reason, detail.ToString());`
`134`	`134`	`}`
Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ public static MessageBody For(`
`145`	`145`	`// status code and then close the connection.`
`146`	`146`	`if (transferCoding != TransferCoding.Chunked)`
`147`	`147`	`{`
`148`		`- BadHttpRequestException.Throw(RequestRejectionReason.FinalTransferCodingNotChunked, in transferEncoding);`
	`148`	`+ BadHttpRequestException.Throw(RequestRejectionReason.FinalTransferCodingNotChunked, transferEncoding);`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`// TODO may push more into the wrapper rather than just calling into the message body`
Original file line number	Diff line number	Diff line change
`@@ -1258,7 +1258,7 @@ protected override bool TryGetValueFast(string key, out StringValues value)`
`1258`	`1258`	`return MaybeUnknown?.TryGetValue(key, out value) ?? false;`
`1259`	`1259`	`}`
`1260`	`1260`
`1261`		`- protected override void SetValueFast(string key, in StringValues value)`
	`1261`	`+ protected override void SetValueFast(string key, StringValues value)`
`1262`	`1262`	`{`
`1263`	`1263`	`switch (key.Length)`
`1264`	`1264`	`{`
`@@ -1606,7 +1606,7 @@ protected override void SetValueFast(string key, in StringValues value)`
`1606`	`1606`	`SetValueUnknown(key, value);`
`1607`	`1607`	`}`
`1608`	`1608`
`1609`		`- protected override bool AddValueFast(string key, in StringValues value)`
	`1609`	`+ protected override bool AddValueFast(string key, StringValues value)`
`1610`	`1610`	`{`
`1611`	`1611`	`switch (key.Length)`
`1612`	`1612`	`{`
`@@ -5337,25 +5337,25 @@ public StringValues HeaderContentLength`
`5337`	`5337`	`}`
`5338`	`5338`	`}`
`5339`	`5339`
`5340`		`- public void SetRawConnection(in StringValues value, byte[] raw)`
	`5340`	`+ public void SetRawConnection(StringValues value, byte[] raw)`
`5341`	`5341`	`{`
`5342`	`5342`	`_bits \|= 0x2L;`
`5343`	`5343`	`_headers._Connection = value;`
`5344`	`5344`	`_headers._rawConnection = raw;`
`5345`	`5345`	`}`
`5346`		`- public void SetRawDate(in StringValues value, byte[] raw)`
	`5346`	`+ public void SetRawDate(StringValues value, byte[] raw)`
`5347`	`5347`	`{`
`5348`	`5348`	`_bits \|= 0x4L;`
`5349`	`5349`	`_headers._Date = value;`
`5350`	`5350`	`_headers._rawDate = raw;`
`5351`	`5351`	`}`
`5352`		`- public void SetRawTransferEncoding(in StringValues value, byte[] raw)`
	`5352`	`+ public void SetRawTransferEncoding(StringValues value, byte[] raw)`
`5353`	`5353`	`{`
`5354`	`5354`	`_bits \|= 0x40L;`
`5355`	`5355`	`_headers._TransferEncoding = value;`
`5356`	`5356`	`_headers._rawTransferEncoding = raw;`
`5357`	`5357`	`}`
`5358`		`- public void SetRawServer(in StringValues value, byte[] raw)`
	`5358`	`+ public void SetRawServer(StringValues value, byte[] raw)`
`5359`	`5359`	`{`
`5360`	`5360`	`_bits \|= 0x2000000L;`
`5361`	`5361`	`_headers._Server = value;`
`@@ -5776,7 +5776,7 @@ protected override bool TryGetValueFast(string key, out StringValues value)`
`5776`	`5776`	`return MaybeUnknown?.TryGetValue(key, out value) ?? false;`
`5777`	`5777`	`}`
`5778`	`5778`
`5779`		`- protected override void SetValueFast(string key, in StringValues value)`
	`5779`	`+ protected override void SetValueFast(string key, StringValues value)`
`5780`	`5780`	`{`
`5781`	`5781`	`ValidateHeaderValueCharacters(value);`
`5782`	`5782`	`switch (key.Length)`
`@@ -6081,7 +6081,7 @@ protected override void SetValueFast(string key, in StringValues value)`
`6081`	`6081`	`SetValueUnknown(key, value);`
`6082`	`6082`	`}`
`6083`	`6083`
`6084`		`- protected override bool AddValueFast(string key, in StringValues value)`
	`6084`	`+ protected override bool AddValueFast(string key, StringValues value)`
`6085`	`6085`	`{`
`6086`	`6086`	`ValidateHeaderValueCharacters(value);`
`6087`	`6087`	`switch (key.Length)`
`@@ -8589,7 +8589,7 @@ protected override bool TryGetValueFast(string key, out StringValues value)`
`8589`	`8589`	`return MaybeUnknown?.TryGetValue(key, out value) ?? false;`
`8590`	`8590`	`}`
`8591`	`8591`
`8592`		`- protected override void SetValueFast(string key, in StringValues value)`
	`8592`	`+ protected override void SetValueFast(string key, StringValues value)`
`8593`	`8593`	`{`
`8594`	`8594`	`ValidateHeaderValueCharacters(value);`
`8595`	`8595`	`switch (key.Length)`
`@@ -8609,7 +8609,7 @@ protected override void SetValueFast(string key, in StringValues value)`
`8609`	`8609`	`SetValueUnknown(key, value);`
`8610`	`8610`	`}`
`8611`	`8611`
`8612`		`- protected override bool AddValueFast(string key, in StringValues value)`
	`8612`	`+ protected override bool AddValueFast(string key, StringValues value)`
`8613`	`8613`	`{`
`8614`	`8614`	`ValidateHeaderValueCharacters(value);`
`8615`	`8615`	`switch (key.Length)`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ public void Reset()`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	`[MethodImpl(MethodImplOptions.NoInlining)]`
`124`		`- protected static StringValues AppendValue(in StringValues existing, string append)`
	`124`	`+ protected static StringValues AppendValue(StringValues existing, string append)`
`125`	`125`	`{`
`126`	`126`	`return StringValues.Concat(existing, append);`
`127`	`127`	`}`
`@@ -157,10 +157,10 @@ protected virtual int GetCountFast()`
`157`	`157`	`protected virtual bool TryGetValueFast(string key, out StringValues value)`
`158`	`158`	`{ throw new NotImplementedException(); }`
`159`	`159`
`160`		`- protected virtual void SetValueFast(string key, in StringValues value)`
	`160`	`+ protected virtual void SetValueFast(string key, StringValues value)`
`161`	`161`	`{ throw new NotImplementedException(); }`
`162`	`162`
`163`		`- protected virtual bool AddValueFast(string key, in StringValues value)`
	`163`	`+ protected virtual bool AddValueFast(string key, StringValues value)`
`164`	`164`	`{ throw new NotImplementedException(); }`
`165`	`165`
`166`	`166`	`protected virtual bool RemoveFast(string key)`
`@@ -259,7 +259,7 @@ bool IDictionary<string, StringValues>.TryGetValue(string key, out StringValues`
`259`	`259`	`return TryGetValueFast(key, out value);`
`260`	`260`	`}`
`261`	`261`
`262`		`- public static void ValidateHeaderValueCharacters(in StringValues headerValues)`
	`262`	`+ public static void ValidateHeaderValueCharacters(StringValues headerValues)`
`263`	`263`	`{`
`264`	`264`	`var count = headerValues.Count;`
`265`	`265`	`for (var i = 0; i < count; i++)`
`@@ -290,7 +290,7 @@ public static void ValidateHeaderNameCharacters(string headerCharacters)`
`290`	`290`	`}`
`291`	`291`	`}`
`292`	`292`
`293`		`- public static unsafe ConnectionOptions ParseConnection(in StringValues connection)`
	`293`	`+ public static unsafe ConnectionOptions ParseConnection(StringValues connection)`
`294`	`294`	`{`
`295`	`295`	`var connectionOptions = ConnectionOptions.None;`
`296`	`296`
`@@ -392,7 +392,7 @@ public static unsafe ConnectionOptions ParseConnection(in StringValues connectio`
`392`	`392`	`return connectionOptions;`
`393`	`393`	`}`
`394`	`394`
`395`		`- public static unsafe TransferCoding GetFinalTransferCoding(in StringValues transferEncoding)`
	`395`	`+ public static unsafe TransferCoding GetFinalTransferCoding(StringValues transferEncoding)`
`396`	`396`	`{`
`397`	`397`	`var transferEncodingOptions = TransferCoding.None;`
`398`	`398`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ private static long ParseContentLength(string value)`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`[MethodImpl(MethodImplOptions.NoInlining)]`
`27`		`- private void SetValueUnknown(string key, in StringValues value)`
	`27`	`+ private void SetValueUnknown(string key, StringValues value)`
`28`	`28`	`{`
`29`	`29`	`Unknown[key] = value;`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ private static void ThrowInvalidContentLengthException(string value)`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`[MethodImpl(MethodImplOptions.NoInlining)]`
`67`		`- private void SetValueUnknown(string key, in StringValues value)`
	`67`	`+ private void SetValueUnknown(string key, StringValues value)`
`68`	`68`	`{`
`69`	`69`	`ValidateHeaderNameCharacters(key);`
`70`	`70`	`Unknown[key] = value;`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ protected override IEnumerator<KeyValuePair<string, StringValues>> GetEnumerator`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`[MethodImpl(MethodImplOptions.NoInlining)]`
`25`		`- private void SetValueUnknown(string key, in StringValues value)`
	`25`	`+ private void SetValueUnknown(string key, StringValues value)`
`26`	`26`	`{`
`27`	`27`	`ValidateHeaderNameCharacters(key);`
`28`	`28`	`Unknown[key] = value;`