Skip to content

Commit 5fadbcb

Browse files
authored
Upgrade to VS2017 (#76)
1 parent cc29517 commit 5fadbcb

16 files changed

+100
-337
lines changed

AspNetCoreModule.sln

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
Microsoft Visual Studio Solution File, Format Version 12.00
3-
# Visual Studio 14
4-
VisualStudioVersion = 14.0.25420.1
3+
# Visual Studio 15
4+
VisualStudioVersion = 15.0.26224.1
55
MinimumVisualStudioVersion = 10.0.40219.1
66
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "AspNetCore", "src\AspNetCore\AspNetCore.vcxproj", "{439824F9-1455-4CC4-BD79-B44FA0A16552}"
77
ProjectSection(ProjectDependencies) = postProject
@@ -12,16 +12,16 @@ Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "IISLib", "src\IISLib\IISLib
1212
EndProject
1313
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "test", "test", "{02F461DC-5166-4E88-AAD5-CF110016A647}"
1414
EndProject
15-
Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "AspNetCoreModule.Test", "test\AspNetCoreModule.Test\AspNetCoreModule.Test.xproj", "{4DDA7560-AA29-4161-A5EA-A7E8F3997321}"
15+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{FDD2EDF8-1B62-4978-9815-9D95260B8B91}"
1616
EndProject
17-
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{2097C03C-E2F7-4396-B3BC-4335F1B87B5E}"
18-
ProjectSection(SolutionItems) = preProject
19-
global.json = global.json
20-
EndProjectSection
17+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AspNetCoreModule.Test", "test\AspNetCoreModule.Test\AspNetCoreModule.Test.csproj", "{4DDA7560-AA29-4161-A5EA-A7E8F3997321}"
2118
EndProject
22-
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{FDD2EDF8-1B62-4978-9815-9D95260B8B91}"
19+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "AspNetCoreModule.TestSites.Standard", "test\AspNetCoreModule.TestSites.Standard\AspNetCoreModule.TestSites.Standard.csproj", "{030225D8-4EE8-47E5-B692-2A96B3B51A38}"
2320
EndProject
24-
Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "AspnetCoreModule.TestSites.Standard", "test\AspNetCoreModule.TestSites.Standard\AspnetCoreModule.TestSites.Standard.xproj", "{030225D8-4EE8-47E5-B692-2A96B3B51A38}"
21+
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{0EF45656-B25D-40D8-959C-726EAF185E60}"
22+
ProjectSection(SolutionItems) = preProject
23+
NuGet.Config = NuGet.Config
24+
EndProjectSection
2525
EndProject
2626
Global
2727
GlobalSection(SolutionConfigurationPlatforms) = preSolution

Build/repo.props

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<Project>
2+
<ItemGroup>
3+
<ExcludeFromTest Include="$(RepositoryRoot)test\AspNetCoreModule.TestSites.Standard\*.csproj" />
4+
<ExcludeFromTest Include="$(RepositoryRoot)test\AspNetCoreModule.Test\*.csproj" Condition="'$(OS)' != 'Windows_NT'" />
5+
</ItemGroup>
6+
</Project>

build.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ cd $PSScriptRoot
3333
$repoFolder = $PSScriptRoot
3434
$env:REPO_FOLDER = $repoFolder
3535

36-
$koreBuildZip="https://github.com/aspnet/KoreBuild/archive/dev.zip"
36+
$koreBuildZip="https://github.com/aspnet/KoreBuild/archive/feature/msbuild.zip"
3737
if ($env:KOREBUILD_ZIP)
3838
{
3939
$koreBuildZip=$env:KOREBUILD_ZIP

global.json

Lines changed: 0 additions & 3 deletions
This file was deleted.

test/AspNetCoreModule.Test/AspNetCoreModule.Test.ForVS.csproj

Lines changed: 0 additions & 155 deletions
This file was deleted.

test/AspNetCoreModule.Test/AspNetCoreModule.Test.xproj

Lines changed: 0 additions & 20 deletions
This file was deleted.

test/AspNetCoreModule.Test/Framework/IISConfigUtility.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using AspNetCoreModule.Test.HttpClientHelper;
55
using Microsoft.Web.Administration;
66
using System;
7-
using System.Collections.ObjectModel;
87
using System.IO;
98
using System.ServiceProcess;
109
using System.Threading;

test/AspNetCoreModule.Test/Framework/InitializeTestMachine.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ public class InitializeTestMachine : IDisposable
2727

2828
public InitializeTestMachine()
2929
{
30+
if (Environment.Is64BitOperatingSystem && !Environment.Is64BitProcess)
31+
{
32+
TestUtility.LogInformation("Error!!! Skipping to run InitializeTestMachine::InitializeTestMachine() because the test process is started on syswow mode");
33+
throw new NotSupportedException("Running this test progrom in syswow64 mode is not supported");
34+
}
3035
_referenceCount++;
3136

3237
if (_referenceCount == 1)

test/AspNetCoreModule.Test/Framework/TestUtility.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ public static string RunPowershellScript(string scriptText)
705705

706706
// create Powershell runspace
707707
Runspace runspace = RunspaceFactory.CreateRunspace();
708-
708+
709709
// open it
710710
runspace.Open();
711711

test/AspNetCoreModule.Test/FunctionalTestHelper.cs

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1041,15 +1041,12 @@ public static async Task DoClientCertificateMappingTest(IISConfigUtility.AppPool
10411041

10421042
// Create a new local administrator user
10431043
string userName = "tempuser" + TestUtility.RandomString(5);
1044-
string password = "AncmTest123!";
1045-
string temp = TestUtility.RunPowershellScript("( Get-LocalUser -Name " + userName + " 2> $null ).Name");
1046-
if (temp == userName)
1047-
{
1048-
temp = TestUtility.RunPowershellScript("net localgroup administrators /Delete " + userName);
1049-
temp = TestUtility.RunPowershellScript("net user " + userName + " /Delete");
1050-
}
1044+
string password = "AncmTest123!";
1045+
string temp;
1046+
temp = TestUtility.RunPowershellScript("net localgroup IIS_IUSRS /Delete " + userName);
1047+
temp = TestUtility.RunPowershellScript("net user " + userName + " /Delete");
10511048
temp = TestUtility.RunPowershellScript("net user " + userName + " " + password + " /ADD");
1052-
temp = TestUtility.RunPowershellScript("net localgroup administrators /Add " + userName);
1049+
temp = TestUtility.RunPowershellScript("net localgroup IIS_IUSRS /Add " + userName);
10531050

10541051
// Get public key of the client certificate and Configure OnetToOneClientCertificateMapping the public key and disable anonymous authentication and set SSL flags for Client certificate authentication
10551052
string publicKey = iisConfig.GetCertificatePublicKey(thumbPrintForClientAuthentication, @"Cert:\CurrentUser\My");
@@ -1102,7 +1099,7 @@ public static async Task DoClientCertificateMappingTest(IISConfigUtility.AppPool
11021099
Assert.True(result.Contains("403.7"));
11031100

11041101
// Clean up user
1105-
temp = TestUtility.RunPowershellScript("net localgroup administrators /Delete " + userName);
1102+
temp = TestUtility.RunPowershellScript("net localgroup IIS_IUSRS /Delete " + userName);
11061103
temp = TestUtility.RunPowershellScript("net user " + userName + " /Delete");
11071104

11081105
// Remove the SSL Certificate mapping

0 commit comments

Comments
 (0)