Address feedback from code review

Author: captainsafia

src/Framework/Analyzer/src/DelegateEndpoints/DelegateEndpointFixer.cs

@@ -18,10 +18,7 @@ public partial class DelegateEndpointFixer : CodeFixProvider
 {
     public override ImmutableArray<string> FixableDiagnosticIds { get; } = ImmutableArray.Create(DiagnosticDescriptors.DetectMismatchedParameterOptionality.Id);
 
-    public sealed override FixAllProvider GetFixAllProvider()
-    {
-        return WellKnownFixAllProviders.BatchFixer;
-    }
+    public sealed override FixAllProvider GetFixAllProvider() => WellKnownFixAllProviders.BatchFixer;
 
     public sealed override Task RegisterCodeFixesAsync(CodeFixContext context)
     {

src/Framework/Analyzer/src/DelegateEndpoints/DetectMismatchedParameterOptionality.cs

@@ -20,47 +20,51 @@ private static void DetectMismatchedParameterOptionality(
         IInvocationOperation invocation,
         IMethodSymbol methodSymbol)
     {
+        if (invocation.Arguments.Length < 2)
+        {
+            return;
+        }
+
         var value = invocation.Arguments[1].Value;
         if (value.ConstantValue is not { HasValue: true } constant ||
             constant.Value is not string routeTemplate)
         {
             return;
         }
 
-        var parametersInArguments = methodSymbol.Parameters;
-        var parametersInRoute = GetParametersFromRoute(routeTemplate);
-
-        foreach (var parameter in parametersInArguments)
+        var allDeclarations = methodSymbol.GetAllMethodSymbolsOfPartialParts();
+        foreach (var method in allDeclarations)
         {
-            var isOptional = parameter.IsOptional || parameter.NullableAnnotation != NullableAnnotation.NotAnnotated;
-            var location = parameter.DeclaringSyntaxReferences.SingleOrDefault()?.GetSyntax().GetLocation();
-            var paramName = parameter.Name;
-            var parameterFound = parametersInRoute.TryGetValue(paramName, out var routeParam);
+            var parametersInArguments = method.Parameters;
+            var enumerator = new RouteTokenEnumerator(routeTemplate);
 
-            if (!isOptional && parameterFound && routeParam.IsOptional)
+            while (enumerator.MoveNext())
             {
-                context.ReportDiagnostic(Diagnostic.Create(
-                    DiagnosticDescriptors.DetectMismatchedParameterOptionality,
-                    location,
-                    paramName));
+                foreach (var parameter in parametersInArguments)
+                {
+                    var paramName = parameter.Name;
+                    //  If this is not the methpd parameter associated with the route
+                    // parameter then continue looking for it in the list
+                    if (!enumerator.CurrentName.Equals(paramName.AsSpan(), StringComparison.OrdinalIgnoreCase))
+                    {
+                        continue;
+                    }
+                    var argumentIsOptional = parameter.IsOptional || parameter.NullableAnnotation != NullableAnnotation.NotAnnotated;
+                    var location = parameter.DeclaringSyntaxReferences.SingleOrDefault()?.GetSyntax().GetLocation();
+                    var routeParamIsOptional = enumerator.CurrentQualifiers.IndexOf('?') > -1;
+
+                    if (!argumentIsOptional && routeParamIsOptional)
+                    {
+                        context.ReportDiagnostic(Diagnostic.Create(
+                            DiagnosticDescriptors.DetectMismatchedParameterOptionality,
+                            location,
+                            paramName));
+                    }
+                }
             }
         }
     }
 
-    private static IDictionary<string, RouteParameter> GetParametersFromRoute(string routeTemplate)
-    {
-        var enumerator = new RouteTokenEnumerator(routeTemplate);
-        Dictionary<string, RouteParameter> result = new(StringComparer.OrdinalIgnoreCase);
-        while (enumerator.MoveNext())
-        {
-            var isOptional = enumerator.CurrentQualifiers.IndexOf('?') > -1;
-            result.Add(
-                enumerator.CurrentName.ToString(),
-                new RouteParameter(enumerator.CurrentName.ToString(), isOptional));
-        }
-        return result;
-    }
-
     internal ref struct RouteTokenEnumerator
     {
         private ReadOnlySpan<char> _routeTemplate;
@@ -132,6 +136,4 @@ private static int IndexOf(ReadOnlySpan<char> span, int startIndex, char c)
 
         return -1;
     }
-
-    internal record RouteParameter(string Name, bool IsOptional);
 }

src/Framework/Analyzer/src/DelegateEndpoints/DiagnosticDescriptors.cs

@@ -37,8 +37,8 @@ internal static class DiagnosticDescriptors
 
         internal static readonly DiagnosticDescriptor DetectMismatchedParameterOptionality = new(
             "ASP0006",
-            "Parameter optionality is mismatched",
-            "'{0}' argument should be annotated as optional to match route parameter",
+            "Route parameter and argument optionality is mismatched",
+            "'{0}' argument should be annotated as optional or nullable to match route parameter",
             "Usage",
             DiagnosticSeverity.Warning,
             isEnabledByDefault: true,