-
Notifications
You must be signed in to change notification settings - Fork 693
[release/9.3] Fix SqlServer PowerShell module version to avoid breaking changes in 22.4.5.1 #9958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR backports a fix to ensure that the SqlServer PowerShell module is installed at a specific version (22.3.0) to avoid breaking changes introduced in version 22.4.5.1, which prevented Azure SQL Server deployments.
- Updated the installation command in AzureSqlServerResource.cs to include the -RequiredVersion parameter.
- Propagated the same change across multiple bicep files (api2-roles-mysqlserver.module.bicep, api1-roles-mysqlserver.module.bicep, sql2-roles.module.bicep, sql1-roles.module.bicep) to ensure consistency.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs | Updated PowerShell module install command with explicit version. |
playground/SqlServerScript/AppHost1/api2-roles-mysqlserver.module.bicep | Updated script content to install the specific module version. |
playground/SqlServerScript/AppHost1/api1-roles-mysqlserver.module.bicep | Updated script content to install the specific module version. |
playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql2-roles.module.bicep | Updated script content to install the specific module version. |
playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql1-roles.module.bicep | Updated script content to install the specific module version. |
Backport of #9939 to release/9.3
Customer Impact
Users can't deploy Sql Server database on Azure because the deployment script fails with the updated package.
Testing
Tested manually before and after fix.
Risk
Low
Regression?
Yes