Skip to content

Conversation

sebastienros
Copy link
Member

Backport of #9939 to release/9.3

Customer Impact

Users can't deploy Sql Server database on Azure because the deployment script fails with the updated package.

Testing

Tested manually before and after fix.

Risk

Low

Regression?

Yes

@Copilot Copilot AI review requested due to automatic review settings June 19, 2025 17:02
@sebastienros sebastienros added the Servicing-consider Issue for next servicing release review label Jun 19, 2025
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jun 19, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports a fix to ensure that the SqlServer PowerShell module is installed at a specific version (22.3.0) to avoid breaking changes introduced in version 22.4.5.1, which prevented Azure SQL Server deployments.

  • Updated the installation command in AzureSqlServerResource.cs to include the -RequiredVersion parameter.
  • Propagated the same change across multiple bicep files (api2-roles-mysqlserver.module.bicep, api1-roles-mysqlserver.module.bicep, sql2-roles.module.bicep, sql1-roles.module.bicep) to ensure consistency.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Aspire.Hosting.Azure.Sql/AzureSqlServerResource.cs Updated PowerShell module install command with explicit version.
playground/SqlServerScript/AppHost1/api2-roles-mysqlserver.module.bicep Updated script content to install the specific module version.
playground/SqlServerScript/AppHost1/api1-roles-mysqlserver.module.bicep Updated script content to install the specific module version.
playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql2-roles.module.bicep Updated script content to install the specific module version.
playground/SqlServerEndToEnd/SqlServerEndToEnd.AppHost/sql1-roles.module.bicep Updated script content to install the specific module version.

@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 19, 2025
@danmoseley danmoseley added this to the 9.3.2 milestone Jun 19, 2025
@joperezr joperezr merged commit ce75714 into release/9.3 Jun 19, 2025
177 checks passed
@joperezr joperezr deleted the sebros/powershell branch June 19, 2025 22:24
This was referenced Aug 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants