[CI] Fix azdo builds for main
#9338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-engineering-systems
|
These need to be validated before merging:
|
## What broke?
Template tests run `dotnet test --list-tests` to get the list of tests so they can
be run on separate helix jobs. This run of `dotnet` failed the builds on
azdo with:
```
You must install or update .NET to run this application.
App: /mnt/vss/_work/1/s/artifacts/bin/Aspire.Templates.Tests/Release/net8.0/Aspire.Templates.Tests
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '8.0.0' (x64)
.NET location: /usr/lib/dotnet
The following frameworks were found:
6.0.36 at [/usr/lib/dotnet/shared/Microsoft.NETCore.App]
Learn about framework resolution:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0&arch=x64&rid=ubuntu.22.04-x64
/mnt/vss/_work/1/s/tests/Directory.Build.targets(39,5): error MSB3073: The command ""/mnt/vss/_work/1/s/artifacts/bin/Aspire.Templates.Tests/Release/net8.0/Aspire.Templates.Tests" --filter-no>
##[error]tests/Directory.Build.targets(39,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command ""/mnt/vss/_work/1/s/artifacts/bin/Aspire.Templates.Tests/Release/net8.0/Aspire>
```
## Why did it break?
[1] added a change where that `dotnet test` was run with
`EnvironmentVariables="DOTNET_ROOT=$(DotNetRoot);DOTNET_ROOT_X86=$(DotNetRoot)x86"`,
so it does not use the system dotnet. This helped on Azdo builds where
we have older system dotnet (6.0x).
Then [2] removed that change so the system dotnet on github actions
could be used because a newer one was being installed. But this now
broke the Azdo builds.
To fix this set the DOTNET_ROOT on Azdo builds, so the correct dotnet is
used.
References:
1.
commit 0af9e78
Author: Youssef Victor <youssefvictor00@gmail.com>
Date: Sat Apr 19 14:34:54 2025 +0200
Revert to MTP and disable server capability as a workaround (dotnet#8833)
2.
```
commit 6ca2de9
Author: Ankit Jain <radical@gmail.com>
Date: Wed May 14 11:39:18 2025 -0400
[CI] Add PR validation on macOS (dotnet#9287)
```
radical
force-pushed
the
fix-azdo-main
branch
2 times, most recently
from
1d49b4f to
953a381
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Azure DevOps builds by ensuring that the correct .NET installation is used for the test and build steps.
- Updated the test step environment variable to set DOTNET_ROOT
- Added/updated the DOTNET_ROOT environment variable for the build step
Comments suppressed due to low confidence (1)
eng/pipelines/templates/BuildAndTest.yml:64
- [nitpick] The path separators for DOTNET_ROOT differ between the test step (using backslashes) and the build step (using forward slashes). Consider using consistent path separators to improve readability and reduce potential issues in cross-platform environments.
+ DOTNET_ROOT: $(Build.SourcesDirectory)\ .dotnet
danmoseley
approved these changes
May 15, 2025
…cess_RedirectToResources Issue: dotnet#9345
|
Should #9261 be reinstated now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What broke?
Template tests run
dotnet test --list-teststo get the list of tests so they canbe run on separate helix jobs. This run of
dotnetfailed the builds onazdo with:
Why did it break?
[1] added a change where that
dotnet testwas run withEnvironmentVariables="DOTNET_ROOT=$(DotNetRoot);DOTNET_ROOT_X86=$(DotNetRoot)x86",so it does not use the system dotnet. This helped on Azdo builds where
we have older system dotnet (6.0x).
Then [2] removed that change so the system dotnet on github actions
could be used because a newer one was being installed. But this now
broke the Azdo builds.
To fix this set the
DOTNET_ROOTon Azdo builds, so the correct dotnet isused.
References:
1.
commit 0af9e78
Author: Youssef Victor youssefvictor00@gmail.com
Date: Sat Apr 19 14:34:54 2025 +0200