Skip to content

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Apr 8, 2025

Implement a version selection feature for Aspire project templates, allowing users to choose from available versions, including pre-release options. Update related methods and interfaces to support this functionality.

Fixes #8627
Fixes #8597
Fixes #8626

@Copilot Copilot AI review requested due to automatic review settings April 8, 2025 09:42
@mitchdenny mitchdenny linked an issue Apr 8, 2025 that may be closed by this pull request
@mitchdenny mitchdenny requested review from davidfowl and removed request for Copilot April 8, 2025 09:42
@mitchdenny mitchdenny self-assigned this Apr 8, 2025
@mitchdenny mitchdenny added this to the 9.2 milestone Apr 8, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

davidfowl and others added 2 commits April 8, 2025 02:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@davidfowl davidfowl closed this Apr 8, 2025
@davidfowl davidfowl reopened this Apr 8, 2025
@davidfowl davidfowl merged commit e5d5aa9 into main Apr 8, 2025
175 checks passed
@davidfowl davidfowl deleted the mitchdenny/aspire-new-template-selection branch April 8, 2025 16:15
@mitchdenny
Copy link
Member Author

/backport to release/9.2

Copy link
Contributor

github-actions bot commented Apr 8, 2025

Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14343466841

radical pushed a commit that referenced this pull request Apr 9, 2025
* Introduce version selecto to aspire new

* Update src/Aspire.Cli/Commands/NewCommand.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/Aspire.Cli/Commands/NewCommand.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Youssef1313 added a commit that referenced this pull request Apr 9, 2025
* Migrate from VSTest to Microsoft.Testing.Platform

* Address TODO

* Cleanup stuff around runsettings

* Add comment

* Progress

* Remove locale

* Always show live output

* Restore test session timeout

* Fix timeout

* Fix typo

* Fix duplicate commnand-line options

* Fix Linux

* Fix for Linux

* Fix

* Fix

* Filter failing

* Fix

* ignore exit code 8

* Fix extra dot

* Ignore exit code

* Fix duplicate --ignore-exit-code

* Fix playground tests on helix

* Move to RepoTesting.props

* Fix results dir

* Fix

* Progress

* Fix duplicate command-line option

* Missing report-trx

* Run executable

* Address review comments

* Revert "Run executable"

This reverts commit d10e168.

* dotnet dll

* Introduce version selector for Aspire templates (#8625)

* Introduce version selecto to aspire new

* Update src/Aspire.Cli/Commands/NewCommand.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/Aspire.Cli/Commands/NewCommand.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Error handling for GetCapabilitiesAsync connection issues (#8614)

* Error out when GetCapabiltiesAsync is missing or unexpected exception occurs.

* Update src/Aspire.Cli/DotNetCliRunner.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Obsolete AddAzureContainerAppsInfrastructure (#8639)

* Obsolete AddAzureContainerAppsInfrastructure

This method is no longer meant to be used. Instead developers should be calling AddAzureContainerAppEnvironment.

Covert the tests using this API to the new API

* Fix volume output naming issue

We weren't discriminating between volumes and bindmounts, which caused a cache collision.

* Switch the prefix at the beginning

* Add error handling for package updates in workflow (#8390)

* Filter out tracing health endpoints in service defaults templates (#8643)

* Filter out tracing health endpoints

Fixes #8580

* Fix typo

* Show neutral icon for container exiting with status code 0 (#8477)

* Show neutral icon for container exiting with status code 0

* Show info/stop icons for all exited resources with status code 0

* Add finished test for custom resource, remove exit code expectation

* update tests

* [tests] Correctly mark Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests with RequiresPlaywright (#8647)

* [tests] Skip generating Directory.Packages.Versions.props for Test (#8621)

.. Utility projects.

* Fix running playground tests on windows

---------

Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
Co-authored-by: Mitch Denny <midenn@microsoft.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com>
Co-authored-by: Damian Edwards <damian@damianedwards.com>
Co-authored-by: Adam Ratzman <adam@adamratzman.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.