[CI] Use an in-repo copy of devcerts installation script#8548
Merged
danmoseley merged 1 commit intodotnet:mainfrom Apr 4, 2025
Merged
[CI] Use an in-repo copy of devcerts installation script#8548danmoseley merged 1 commit intodotnet:mainfrom
danmoseley merged 1 commit intodotnet:mainfrom
Conversation
radical
requested review from
DamianEdwards,
RussKie,
Copilot,
danmoseley and
joperezr
github-actions
bot
added
the
area-engineering-systems
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (3)
- tests/external-scripts/common.sh: Language not supported
- tests/external-scripts/ubuntu-create-dotnet-devcert.sh: Language not supported
- tests/helix/send-to-helix-inner.proj: Language not supported
Comments suppressed due to low confidence (1)
eng/pipelines/templates/BuildAndTest.yml:63
- Ensure the file path matches the actual location of the script. The README is placed in tests/external-scripts, so if the script is also there, the pipeline reference should be updated accordingly.
- script: $(Build.SourcesDirectory)/external-scripts/ubuntu-create-dotnet-devcert.sh
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (3)
- tests/external-scripts/common.sh: Language not supported
- tests/external-scripts/ubuntu-create-dotnet-devcert.sh: Language not supported
- tests/helix/send-to-helix-inner.proj: Language not supported
Comments suppressed due to low confidence (1)
eng/pipelines/templates/BuildAndTest.yml:63
- Ensure that the local script 'ubuntu-create-dotnet-devcert.sh' is marked as executable in the repository (or explicitly set executable in the pipeline) to prevent CI failures.
script: $(Build.SourcesDirectory)/tests/external-scripts/ubuntu-create-dotnet-devcert.sh
RussKie
approved these changes
Apr 4, 2025
Member
Author
|
/backport to release/9.2 |
Contributor
|
Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14278420973 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.