Skip to content

Conversation

sebastienros
Copy link
Member

Move database script annotations to their respective projects and make them internal.

Contributes to #7811

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot AI review requested due to automatic review settings April 3, 2025 22:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Aspire.Hosting.SqlServer/SqlServerCreateDatabaseScriptAnnotation.cs:6

  • [nitpick] The namespace does not reflect the file's location under Aspire.Hosting.SqlServer. Consider using 'namespace Aspire.Hosting.SqlServer;' for consistency.
namespace Aspire.Hosting;

@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 3, 2025
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastienros
Copy link
Member Author

/backport to release/9.2

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14254064876

@sebastienros sebastienros merged commit 70c8925 into main Apr 3, 2025
175 checks passed
@sebastienros sebastienros deleted the sebros/scriptannotation branch April 3, 2025 23:07
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants