Skip to content

Add NO-MERGE label to auto created api-diff PR #8479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Add NO-MERGE label to auto created api-diff PR #8479

merged 1 commit into from
Apr 2, 2025

Conversation

Alirexaa
Copy link
Contributor

@Alirexaa Alirexaa commented Apr 1, 2025

Add NO-MERGE label by default to [Automated] Update API Surface Area PR.

@Copilot Copilot AI review requested due to automatic review settings April 1, 2025 20:34
Copilot
Copilot AI reviewed Apr 1, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the "NO-MERGE" label by default to automatically created API diff PRs to prevent unintended merging.

  • Adds a new labels section in the API diffs workflow
  • Ensures the automated PRs are flagged as non-mergeable

@github-actions github-actions bot added the area-engineering-systems infrastructure helix infra engineering repo stuff label Apr 1, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 1, 2025
@mitchdenny
Copy link
Member

/cc @joperezr

@RussKie
Copy link
Contributor

RussKie commented Apr 2, 2025

Add NO-MERGE label by default to [Automated] Update API Surface Area PR.

Could you please clarify the reasoning?

@RussKie RussKie added the needs-author-action An issue or pull request that requires more info or actions from the author. label Apr 2, 2025
@Alirexaa
Copy link
Contributor Author

Alirexaa commented Apr 2, 2025

Could you please clarify the reasoning?

That PR ([Automated] Update API Surface Area) should be merged before a new release (it's often the last PR), and I have noticed a few times that the team added this label to that PR manually. So, this will automate that and prevent unintended merging.

@dotnet-policy-service dotnet-policy-service bot removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Apr 2, 2025
@danmoseley danmoseley merged commit 6a12013 into dotnet:main Apr 2, 2025
171 checks passed
@danmoseley
Copy link
Member

thanks @Alirexaa good idea.

@Alirexaa Alirexaa deleted the patch-1 branch April 2, 2025 16:21
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@danmoseley danmoseley danmoseley approved these changes

Assignees
No one assigned
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alirexaa @mitchdenny @RussKie @danmoseley