Makes VolumeNameGenerator public #6531
Conversation
dotnet-policy-service
bot
added
the
community-contribution
Co-authored-by: Dan Moseley <danmose@microsoft.com>
| /// <param name="builder">The resource builder.</param> | ||
| /// <param name="suffix">The suffix to append to the volume name.</param> | ||
| /// <returns>The volume name.</returns> | ||
| /// <exception cref="ArgumentException"></exception> | ||
| public static string CreateVolumeName<T>(IResourceBuilder<T> builder, string suffix) where T : IResource |
There was a problem hiding this comment.
Probably want to think about naming here.. duplicative ? VolumeNameGenerator.Generate ?
There was a problem hiding this comment.
I have no preference on this, simply changed the visibility. I agree though, Generate seems more consistent and it’s an opportunity to polish it a bit. I’ll update it
There was a problem hiding this comment.
I have updated to change the name from CreateVolumeName to Generate as suggested.
There was a problem hiding this comment.
@danmoseley Are you good with the changes made?
There was a problem hiding this comment.
seems fine to me. @davidfowl what is the process around public API naming - is this OK?
|
cc @DamianEdwards as he wrote this code |
Co-authored-by: Damian Edwards <damian@damianedwards.com>
|
@los93sol if you put text like Thanks for the contribution, we'd welcome more. |
github-actions
bot
added
the
area-integrations
Makes VolumeNameGenerator public #6490
Microsoft Reviewers: Open in CodeFlow