Skip to content

Conversation

karolz-ms
Copy link
Member

@karolz-ms karolz-ms commented Oct 21, 2024

Description

Adjust timeouts and retry policy for request made from app host to DCP.

Fixes #6392

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No (N/A)
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@davidfowl
Copy link
Member

This needs a backport

@karolz-ms karolz-ms enabled auto-merge (squash) October 22, 2024 00:08
@karolz-ms
Copy link
Member Author

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11450708522

Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... ran this locally.

@karolz-ms karolz-ms merged commit 8685dd0 into main Oct 22, 2024
9 checks passed
@karolz-ms karolz-ms deleted the dev/karolz/issue6392 branch October 22, 2024 01:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restarting containers using docker file fails
4 participants