Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support icon variant on commands, make start and stop icons filled #5839

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 23, 2024

Description

Consistent feedback on the start/stop/restart icons was the stop icon looked like an empty checkbox. The standard for this kind of UI is to have filled icons. For example, VS debugging start/stop buttons are filled.

This PR:

  • Adds icon variant option to commands. Defaults to regular.
  • Changes start and stop icons to be filled icons.
  • Changes the icon size from 20 to 16. Size 20 filled icons felt too big. Size 16 looks good.
  • Fixes error when command doesn't have an icon.

Demo:
image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better.

@JamesNK JamesNK enabled auto-merge (squash) September 23, 2024 01:56
@JamesNK
Copy link
Member Author

JamesNK commented Sep 23, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK
Copy link
Member Author

JamesNK commented Sep 23, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK merged commit 1fe9da2 into main Sep 23, 2024
11 checks passed
@JamesNK JamesNK deleted the jamesnk/improve-startstoprestarticons branch September 23, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants