[release/8.2] Fix dashboard auth when unsecured #5532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
High impact regression being hit by a lot of customers. Low Risk, validated changes and introduced tests to catch regressions. Approved. Thanks @JamesNK |
joperezr
approved these changes
Sep 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5499 to release/8.2
/cc @JamesNK
Changes to auth caused the dashboard's unsecured mode to fail. Users are presented with a message that authorization failed. The dashboard isn't usage.
Customer Impact
This will impact people using the standalone dashboard most. They're most likely to configure the dashboard to run in unsecured mode. The dashboard becomes unusable.
The workaround is switching to using browser token (the next easiest to use a local machine). However, the workaround isn't discoverable. There is no indication that it is the solution to the problem.
People using Aspire via the IDE use browser token auth by default. Because it just works, there isn't a reason to go unsecured. They're unimpacted unless they've added explicit configuration.
Testing
"DOTNET_DASHBOARD_UNSECURED_ALLOW_ANONYMOUS": "true"to launchSettings.json. Confirmed the UI is visible:Risk
Low. There shouldn't be any change in behavior when other auth modes (browser token and OpenID connect) are configured.
Regression?
Yes. Unsecured mode worked in 8.1.
Microsoft Reviewers: Open in CodeFlow