[release/8.0] Make sure bind mount paths are relative to the app host directory #3494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ade it so that bind mounts annotations are resolved relative to the app host directory by default. - Bind mounts without a rooted path will throw an error. - Removed logic from ApplicationExecutor that checks the annotation data since this is checked in the constructor. - Added tests (moved tests to Containers folder)
ghost
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
eerhardt
approved these changes
Apr 8, 2024
danmoseley
added
Servicing-approved
davidfowl
approved these changes
Apr 9, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3467 to release/8.0
/cc @davidfowl
Customer Impact
Today paths to bind mounts are resolved using CWD, which is different to projects, executables and pretty much everything else in the app model today. This change makes bind mounts resolve relative paths relative to the app host directory.
Testing
Added unit tests and did manual testing.
Risk
Low, we were already resolving the relative path to
Regression?
No.
Microsoft Reviewers: Open in CodeFlow