[release/8.0]: Print the URL with the token when we print the dashboard URL #3475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Today we're waiting until the app started and that can take a long time when provisioning resources. Instead, just print the token url when we print the dashboard url.
ghost
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
davidfowl
changed the title
davidfowl
changed the title
danmoseley
added
Servicing-approved
JamesNK
approved these changes
Apr 8, 2024
mitchdenny
approved these changes
Apr 8, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a release/8.0 version of #3472 (main contains a bigger dashboard refactoring so this is a manual change to reduce the risk.)
After the dashboard auth changes, we are waiting until the application has fully started before showing the URL with the token to authenticate, and that can take a long time when provisioning azure resources. Instead, just print the URL with the token when we print the dashboard URL.
Customer Impact
This makes it possible to login to the dashboard when using azure resources. Without it, customers would potentially need to wait until all resources are done provisioning to use the dashboard (with the correct auth token).
Testing
Existing test pass, and manual verification.
Risk
Low
Microsoft Reviewers: Open in CodeFlow