Don't wait until after we've started the entire app to print the token #3472
+87
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Print it right after we print the dashboard url - Refactored the dashboard resource to use DashboardOptions instead of DcpOptions
ghost
added
the
area-app-model
davidfowl
commented
Apr 8, 2024
|
|
||
| if (!string.IsNullOrEmpty(browserToken)) | ||
| { | ||
| LoggingHelpers.WriteDashboardUrl(distributedApplicationLogger, dashboardUrls, browserToken); |
JamesNK
approved these changes
Apr 8, 2024
davidfowl
added a commit
that referenced
this pull request
Apr 10, 2024
#3472) - Print it right after we print the dashboard url - Refactored the dashboard resource to use DashboardOptions instead of DcpOptions
joperezr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Improve service address allocation (#3294) * Improve service address allocation Should fix #3265 * Make the dashboard an appmodel resource (#3453) * Make the dashboard an appmodel resource - Moved dashboard resource into a lifecycle hook instead of making it a dcp resource. This removes the specialized code from ApplicationExecutor from knowing about the dashboard. As a result of this change I also cleaned up how we configure and validate dcp options to use IConfigureOptions and IValidateOptions. - Added tests for the dashboard resource - Made a change to ApplicationExecutor to allow resources that start as hidden to remain hidden. - Added hidden to a new known resource states class - Added more test cases * Only add dashboard services if the dashboard is enabled (#3489) * Only add dashboard services if the dashboard is enabled * Don't wait until after we've started the entire app to print the token (#3472) - Print it right after we print the dashboard url - Refactored the dashboard resource to use DashboardOptions instead of DcpOptions --------- Co-authored-by: Karol Zadora-Przylecki <karolz@microsoft.com> Co-authored-by: Reuben Bond <203839+ReubenBond@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS: We'll need to backport this to p6.
Microsoft Reviewers: Open in CodeFlow